MRG: Update time slider label#7263
Merged
larsoner merged 4 commits intomne-tools:masterfrom Jan 30, 2020
Merged
Conversation
86 tasks
Codecov Report
@@ Coverage Diff @@
## master #7263 +/- ##
==========================================
- Coverage 89.79% 89.79% -0.01%
==========================================
Files 447 447
Lines 80506 80518 +12
Branches 12873 12878 +5
==========================================
+ Hits 72289 72299 +10
- Misses 5390 5391 +1
- Partials 2827 2828 +1 |
Member
|
works great except that now if I hide the controls I've lost the time information. It should appear as before. |
Contributor
Author
|
Good catch! I'll fix this one. |
Contributor
Author
|
Actually @agramfort I see 2 ways to solve this issue:
|
Member
|
We want a time label visible, it's useful. Why not show the old actor when not in interactive mode, but hide it in interactive mode? It won't scale in non-interactive mode but I think that's okay. (Personally I think it would be better if none of the text actors scaled, it's how standard UI and plotters like mpl work.) |
Contributor
Author
|
Going for option 1 then |
Member
|
Works for me as well, thanks @GuillaumeFavelier |
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Update time slider * Remove unused variable * Refactor set_time_point * Bring back time_actor when the interface is hidden
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Update time slider * Remove unused variable * Refactor set_time_point * Bring back time_actor when the interface is hidden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the slider time label instead of the default time actor. It improves consistency so now the size of the time label scales with the window size.
Known issue
It's an item of #7162