FIX: Add support for hemi=both in _TimeViewer#7253
Merged
agramfort merged 2 commits intomne-tools:masterfrom Jan 24, 2020
Merged
FIX: Add support for hemi=both in _TimeViewer#7253agramfort merged 2 commits intomne-tools:masterfrom
agramfort merged 2 commits intomne-tools:masterfrom
Conversation
Contributor
Author
|
Please let me know if this solves your issue @SophieHerbst. |
Contributor
|
It does - works now for 'both' and 'split'. Thank you @GuillaumeFavelier ! |
Codecov Report
@@ Coverage Diff @@
## master #7253 +/- ##
==========================================
- Coverage 89.79% 89.78% -0.01%
==========================================
Files 445 445
Lines 80271 80264 -7
Branches 12837 12838 +1
==========================================
- Hits 72079 72067 -12
- Misses 5375 5378 +3
- Partials 2817 2819 +2 |
Member
|
thx @GuillaumeFavelier and @SophieHerbst ! |
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Add support for both in _TimeViewer * Port slider position patch from mne-tools#7227
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Add support for both in _TimeViewer * Port slider position patch from mne-tools#7227
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the support of
hemi=bothfor the_TimeViewer. I also ported the patch from #7227.Closes #7250