Delegate notebook detection to PyVista#7240
Merged
agramfort merged 1 commit intomne-tools:masterfrom Jan 22, 2020
Merged
Conversation
larsoner
approved these changes
Jan 22, 2020
Member
|
@SophieHerbst can you try this and see if it fixes your problem? |
Codecov Report
@@ Coverage Diff @@
## master #7240 +/- ##
=========================================
+ Coverage 89.66% 89.7% +0.03%
=========================================
Files 445 445
Lines 79391 80159 +768
Branches 12822 12823 +1
=========================================
+ Hits 71188 71908 +720
- Misses 5342 5427 +85
+ Partials 2861 2824 -37 |
Contributor
|
It works –– awesome! Thank you for the help! |
Member
|
thx @GuillaumeFavelier and @SophieHerbst for the team work ! |
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR delegates the notebook environment detection to the 3d backend instead of using unreliable internal routine
_check_notebook().Fixes #7239.