MRG: Correct camera view_up when necessary#7187
Merged
agramfort merged 2 commits intomne-tools:masterfrom Jan 9, 2020
Merged
Conversation
86 tasks
Member
|
works for me on my macine |
Codecov Report
@@ Coverage Diff @@
## master #7187 +/- ##
==========================================
- Coverage 89.76% 89.75% -0.01%
==========================================
Files 445 445
Lines 79741 79726 -15
Branches 12755 12754 -1
==========================================
- Hits 71579 71562 -17
- Misses 5369 5370 +1
- Partials 2793 2794 +1 |
Contributor
Author
|
Thanks for testing. The case where |
larsoner
approved these changes
Jan 9, 2020
Contributor
Author
|
Does it work now @agramfort ? |
Member
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Correct camera view_up when necessary * Handle the case when elevation is None
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Correct camera view_up when necessary * Handle the case when elevation is None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug with the
dorsalview making the brain disappear (reported in #7153 (comment)).This patch is strongly inspired by mayavi.
It's an item of #7162