MRG: Use latest version 0.23.0 of pyvista instead of master#7150
MRG: Use latest version 0.23.0 of pyvista instead of master#7150agramfort merged 14 commits intomne-tools:masterfrom
Conversation
|
To save us some potential post-merge pain, can you push a commit with |
Codecov Report
@@ Coverage Diff @@
## master #7150 +/- ##
==========================================
+ Coverage 89.75% 89.75% +<.01%
==========================================
Files 444 444
Lines 79312 79328 +16
Branches 12681 12685 +4
==========================================
+ Hits 71185 71201 +16
Misses 5344 5344
Partials 2783 2783 |
|
I've bult the |
|
The merge with |
|
This time Circle failed with: |
|
But Travis is happy now |
|
I've tried to restart the build. @GuillaumeFavelier can you do a test of mprof on the example that fails? |
|
Circle displays the current script or the last script executed with success? Because I don't think |
|
Everything seems fine on the previous version. Azure has a http error: |
|
Result available here: https://17262-1301584-gh.circle-artifacts.com/0/dev/index.html |
|
so we have a regression with pyvista 0.23 :(
… |
|
After investing some Let's go back on |
|
The results are available: https://17307-1301584-gh.circle-artifacts.com/0/dev/index.html AFAIK, pyvista/pyvista#509 (comment) helps for embedding a plotter as a qt widget, this is not something we're interested in here so keeping I think this PR is ready for reviews now @agramfort, @larsoner |
larsoner
left a comment
There was a problem hiding this comment.
LGTM +1 for merge once CircleCI is happy
|
Awesome Thx @GuillaumeFavelier |
…s#7150) * Use version 0.23.0 of pyvista * Trigger CIs [circle full] * Trigger Circle again [circle full] * Trigger Circle [circle full] * TST: Rollback to previous version for regression test [circle full] * TST: Trigger Circle [circle full] * Build doc [circle full] * Build doc [circle full][skip travis][skip azp] * Build doc [circle full][skip travis][skip azp] * Build doc [circle full][skip travis][skip azp] * Build doc [circle full][skip travis][skip azp] * Build doc [circle full][skip travis][skip azp] * Build doc [circle full]
…s#7150) * Use version 0.23.0 of pyvista * Trigger CIs [circle full] * Trigger Circle again [circle full] * Trigger Circle [circle full] * TST: Rollback to previous version for regression test [circle full] * TST: Trigger Circle [circle full] * Build doc [circle full] * Build doc [circle full][skip travis][skip azp] * Build doc [circle full][skip travis][skip azp] * Build doc [circle full][skip travis][skip azp] * Build doc [circle full][skip travis][skip azp] * Build doc [circle full][skip travis][skip azp] * Build doc [circle full]
This PR updates the package requirements for the pyvista 3d backend.