MRG, ENH: Add Label.restrict and faster patch info#7108
Merged
larsoner merged 2 commits intomne-tools:masterfrom Dec 8, 2019
Merged
MRG, ENH: Add Label.restrict and faster patch info#7108larsoner merged 2 commits intomne-tools:masterfrom
larsoner merged 2 commits intomne-tools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7108 +/- ##
==========================================
+ Coverage 89.7% 89.71% +0.01%
==========================================
Files 444 444
Lines 78976 79019 +43
Branches 12674 12677 +3
==========================================
+ Hits 70848 70895 +47
+ Misses 5317 5315 -2
+ Partials 2811 2809 -2 |
Member
Author
|
FYI this now contains some testing fixes that fix failures in current |
Merged
agramfort
reviewed
Dec 8, 2019
agramfort
approved these changes
Dec 8, 2019
Member
Author
|
In that case I'll see if I can fix the docstring checking code, then merge once CIs are happy |
Member
|
sounds good thx
… |
Member
Author
|
There are a lot of errors to fix :( I'll fix the one introduced here, merge, then fix the others in a separate PR. |
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* ENH: Add Label.restrict and faster patch info * FIX: Param
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* ENH: Add Label.restrict and faster patch info * FIX: Param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
label.restrict, the opposite oflabel.filldist_limit=0.to allow using fasterdijkstracalculation in SciPy 1.3+ to only calculate patch informationn_jobsparameter ofadd_distanddist_limitabout parallelization depends on the number of source spaces (it parallelizes oververtnoactually).EDIT: Add test infrastructure workarounds for nilearn using deprecated sklearn stuff hitting us due to sklearn 0.22 release