glossary update: esLORETA definition and links#6883
Merged
larsoner merged 6 commits intomne-tools:masterfrom Oct 2, 2019
Merged
glossary update: esLORETA definition and links#6883larsoner merged 6 commits intomne-tools:masterfrom
larsoner merged 6 commits intomne-tools:masterfrom
Conversation
agramfort
reviewed
Oct 2, 2019
doc/glossary.rst
Outdated
| See :term:`equivalent current dipole`. | ||
|
|
||
| eLORETA and sLORETA | ||
| eLORETA and sLORETA (exact and standardized low resolution brain electromagnetic tomography) are versions of LORETA source estimation technique. It is based on computing the distribution of the current source density throughout full brain volume. See :func:`mne.minimum_norm.apply_inverse`. |
Member
There was a problem hiding this comment.
Suggested change
| eLORETA and sLORETA (exact and standardized low resolution brain electromagnetic tomography) are versions of LORETA source estimation technique. It is based on computing the distribution of the current source density throughout full brain volume. See :func:`mne.minimum_norm.apply_inverse`. | |
| eLORETA and sLORETA (exact and standardized low resolution brain electromagnetic tomography) are linear source estimation techniques, as are dSPM or MNE (:term:`minimum-norm estimation`). sLORETA outputs standardized values such as dSPM, while eLORETA outputs current density estimates like MNE. See :func:`mne.minimum_norm.apply_inverse`. |
drammock
reviewed
Oct 2, 2019
Member
drammock
left a comment
There was a problem hiding this comment.
other than my comments, this looks great!
doc/glossary.rst
Outdated
| See :term:`equivalent current dipole`. | ||
|
|
||
| eLORETA and sLORETA | ||
| eLORETA and sLORETA (exact and standardized low resolution brain electromagnetic tomography) are linear source estimation techniques, as are dSPM or MNE (:term:`minimum-norm estimation`). sLORETA outputs standardized values such as dSPM, while eLORETA outputs current density estimates like MNE. See :func:`mne.minimum_norm.apply_inverse`. |
Member
There was a problem hiding this comment.
Suggested change
| eLORETA and sLORETA (exact and standardized low resolution brain electromagnetic tomography) are linear source estimation techniques, as are dSPM or MNE (:term:`minimum-norm estimation`). sLORETA outputs standardized values such as dSPM, while eLORETA outputs current density estimates like MNE. See :func:`mne.minimum_norm.apply_inverse`. | |
| eLORETA and sLORETA (exact and standardized low resolution brain electromagnetic tomography) are linear source estimation techniques, as are dSPM or :term:`MNE <minimum-norm estimation>`. sLORETA outputs standardized values (like dSPM does), while eLORETA outputs current density estimates (like MNE). See :func:`mne.minimum_norm.apply_inverse` and :ref:`tut-inverse-methods`. |
Member
There was a problem hiding this comment.
It would also be good if this were split over multiple lines, so there is no line-wrapping when viewing the source document. 79 characters is the typical limit.
Codecov Report
@@ Coverage Diff @@
## master #6883 +/- ##
==========================================
- Coverage 89.55% 81.98% -7.57%
==========================================
Files 426 426
Lines 76074 76074
Branches 12415 12415
==========================================
- Hits 68127 62370 -5757
- Misses 5156 10936 +5780
+ Partials 2791 2768 -23 |
larsoner
reviewed
Oct 2, 2019
Member
|
Thanks @NataKozh ! |
drammock
added a commit
to drammock/mne-python
that referenced
this pull request
Oct 2, 2019
Merged
larsoner
pushed a commit
that referenced
this pull request
Oct 3, 2019
* suggestions that got missed in #6883 * fix whitespace and line endings
alexrockhill
pushed a commit
to alexrockhill/mne-python
that referenced
this pull request
Oct 3, 2019
* glossary update: esLORETA definition and links * glossary update: updated definition of eLORETA and sLORETA * glossary update: added period * glossary update: 79characters in line limit * glossary update: added period to HPI definition paragraph * glossary update:eLORETA definition+new link
alexrockhill
pushed a commit
to alexrockhill/mne-python
that referenced
this pull request
Oct 3, 2019
* suggestions that got missed in mne-tools#6883 * fix whitespace and line endings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a brief definition of eLORETA and sLORETA, added links to the inverse operator, HPI and Digitization definitions.