MRG, DOC: Integrate manual parts#6767
Conversation
|
@larsoner I can prioritize this for Monday |
Codecov Report
@@ Coverage Diff @@
## master #6767 +/- ##
=========================================
+ Coverage 89.53% 89.6% +0.06%
=========================================
Files 421 421
Lines 76301 76177 -124
Branches 12478 12450 -28
=========================================
- Hits 68319 68261 -58
+ Misses 5161 5112 -49
+ Partials 2821 2804 -17 |
|
@larsoner I think we should punt on integrating the cookbook at this point. It will be a fair amount of work that I don't think can be done well in time for the 0.19 release. See also mne-tools/mne-tools.github.io#17 |
|
So then do you think this is good enough as is for 0.19? |
|
I think it's good enough that if you want to merge today, you could. If it can wait one more day I would spend a little time tomorrow smoothing out the |
|
I'm fine to wait another day |
|
This pull request introduces 3 alerts when merging 639771a into df66846 - view on LGTM.com new alerts:
|
|
@drammock marked as WIP, feel free to set to MRG once you're happy and I'll take another look, and then if we can get another +1 we should be good for 0.19. |
|
I pushed a PEP8 fix right after yours @drammock |
|
@larsoner I just noticed that the MNE-MATLAB docs got inserted into the MNE-C install pages, was that intentional? |
larsoner
left a comment
There was a problem hiding this comment.
LGTM +1 for merge. The overview page looks nice:
https://15417-1301584-gh.circle-artifacts.com/0/dev/overview/index.html
|
@larsoner @drammock there used to be a page about IO, has that been nuked now? I can find it through the search bar but not through any weblinks. |
|
@jasmainak the page still exists (as you found by searching) but is not very discoverable. This is a known issue; it's true of everything in |
|
merging as we have approvals from @larsoner and @agramfort and me. |
* DOC: Integrate manual parts * integrate SSP-api into tutorial * add URL for MNE-C manual PDF * fix: missing newline at EOF breaks RST rendering? * fix dead crossref * cleanups/tweaks * STY: PEP8 * typos * [skip travis][skip azp] tweaks to install doc sequence
Okay @drammock I got a good start on integrating the
manualparts. Can you look into the last few points, and also do a general cleanup according to whatever you think helps the organization the most?c_legacyprefixes by going through the files, modernizing them, and updating refsmanual/stuff tooverview/algorithms/discussionstutorialsample_dataset.rstinformation directly intodatasets_index.rstssp-api.rstcontent into a tutorial (and/or what in this PR isssp.rst) and remove thessp-api.rstfilemne-tools.github.iorepo somewhere?) and update the currently broken link indoc/links.incDon't look at the
difftoo much, it's insane. Better to just browse the result and iterate.I would like to get this into 0.19 if possible. Do you think it's reasonable for you to get the rest done early next week? If not I can try to spend more time on it.