Skip to content

Make mne/digitization private mne/_digitization#6700

Merged
agramfort merged 9 commits intomne-tools:masterfrom
massich:private_digitization
Aug 23, 2019
Merged

Make mne/digitization private mne/_digitization#6700
agramfort merged 9 commits intomne-tools:masterfrom
massich:private_digitization

Conversation

@massich
Copy link
Copy Markdown
Contributor

@massich massich commented Aug 22, 2019

Takes over #6697

continues #6461

@massich massich force-pushed the private_digitization branch 2 times, most recently from 198b5af to 72c1725 Compare August 22, 2019 14:53
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2019

Codecov Report

Merging #6700 into master will decrease coverage by <.01%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master    #6700      +/-   ##
==========================================
- Coverage   89.42%   89.42%   -0.01%     
==========================================
  Files         417      417              
  Lines       75405    75406       +1     
  Branches    12369    12369              
==========================================
- Hits        67431    67430       -1     
- Misses       5156     5157       +1     
- Partials     2818     2819       +1

@massich massich mentioned this pull request Aug 22, 2019
19 tasks
@massich massich force-pushed the private_digitization branch from 4710600 to ceb1369 Compare August 22, 2019 18:22
@massich
Copy link
Copy Markdown
Contributor Author

massich commented Aug 22, 2019

@agramfort If I didn't mess up this should be green. @larsoner feel free to push if it is not.

@massich
Copy link
Copy Markdown
Contributor Author

massich commented Aug 22, 2019

maybe now?

@agramfort agramfort merged commit 3769993 into mne-tools:master Aug 23, 2019
@agramfort
Copy link
Copy Markdown
Member

Thx @massich

@massich massich deleted the private_digitization branch August 23, 2019 06:56
alexrockhill pushed a commit to alexrockhill/mne-python that referenced this pull request Oct 1, 2019
* avoid Digitization in doc

* WIP: remove DigPoint and Digitization from the doc

* fix whatsnew

* WIP: digitization --> _digitization

* use new watsnew

* update whatsnew

* does this fix Circle? [skip travis][skip azp]

* FIX: why on earth cherry-picking e44d136 didn't work??

* Update base.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants