MRG, DOC: update SSS / Maxfilter tutorial#6642
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6642 +/- ##
======================================
Coverage 89.4% 89.4%
======================================
Files 416 416
Lines 75128 75128
Branches 12349 12349
======================================
Hits 67166 67166
Misses 5130 5130
Partials 2832 2832 |
larsoner
left a comment
There was a problem hiding this comment.
Other than some minor points LGTM!
| # | ||
| # - It is best to choose a chunk duration that evenly divides your data length, | ||
| # so that the effective high-pass filtering is the same for all spans of your | ||
| # data. |
There was a problem hiding this comment.
I'm not sure we really need to recommend this. If you have multiple subjects and/or runs, the only way to really satisfy this is to have the duration vary across subjects and runs, which is probably a worse tradeoff than having just the last chunk for each subject/run possibly be different (at least for typical duration recordings and st_duration choices).
Perhaps instead we should just make a note that the last window could use a longer duration (at worse just shy of 2 * st_duration)?
There was a problem hiding this comment.
LMK if you're happy with the revised wording.
|
@larsoner ready for merge once the CIs come back green (only error last time was CodeSpell). |
|
Thanks @drammock |
* add cHPI to glossary * add crossref target * revise maxfilter tutorial * address Eric's comments * minor docstring fixes * fix codespell
also adds HPI to glossary