MRG: Prepare BTI to refactor for Digitization#6228
Merged
larsoner merged 2 commits intomne-tools:masterfrom Apr 25, 2019
Merged
MRG: Prepare BTI to refactor for Digitization#6228larsoner merged 2 commits intomne-tools:masterfrom
larsoner merged 2 commits intomne-tools:masterfrom
Conversation
Co-authored-by: Teon Brooks <teon.brooks@gmail.com>
Co-authored-by: Teon Brooks <teon.brooks@gmail.com>
b3a9d7f to
3b6b805
Compare
Codecov Report
@@ Coverage Diff @@
## master #6228 +/- ##
===========================================
- Coverage 89.02% 64.48% -24.54%
===========================================
Files 413 413
Lines 74560 74534 -26
Branches 12301 12295 -6
===========================================
- Hits 66374 48063 -18311
- Misses 5281 23830 +18549
+ Partials 2905 2641 -264 |
Contributor
Author
|
This is a qualitative difference between the PR and master. master:
This PR:
|
larsoner
approved these changes
Apr 25, 2019
Member
larsoner
left a comment
There was a problem hiding this comment.
LGTM +1 for merge once CIs (more likely Azure since it's faster) come back happy
Member
|
Thanks @massich @teonbrooks |
agramfort
reviewed
Apr 26, 2019
| from mne.transforms import Transform, combine_transforms, invert_transform | ||
|
|
||
| # from mne.digitization.base import _format_dig_points | ||
| # from mne.digitization import Digitization |
Member
There was a problem hiding this comment.
this will need to be removed in the next PR
massich
pushed a commit
that referenced
this pull request
Apr 26, 2019
jeythekey
pushed a commit
to jeythekey/mne-python
that referenced
this pull request
Apr 27, 2019
* refactor BTI Co-authored-by: Teon Brooks <teon.brooks@gmail.com> * use better naming Co-authored-by: Teon Brooks <teon.brooks@gmail.com>
jeythekey
pushed a commit
to jeythekey/mne-python
that referenced
this pull request
Apr 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdfghjk