DOC: make sure you get a warning when reading onsets which are not timestamps#6184
Merged
cbrnr merged 2 commits intomne-tools:masterfrom Apr 23, 2019
Merged
DOC: make sure you get a warning when reading onsets which are not timestamps#6184cbrnr merged 2 commits intomne-tools:masterfrom
cbrnr merged 2 commits intomne-tools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6184 +/- ##
==========================================
- Coverage 89.01% 89.01% -0.01%
==========================================
Files 410 410
Lines 73883 73894 +11
Branches 12255 12257 +2
==========================================
+ Hits 65765 65774 +9
- Misses 5223 5224 +1
- Partials 2895 2896 +1 |
Contributor
|
LGTM! |
larsoner
reviewed
Apr 22, 2019
mne/tests/test_annotations.py
Outdated
| _assert_annotations_equal(annot, annot2) | ||
|
|
||
| # Test broken .csv that does not use timestamps | ||
| with pytest.warns(RuntimeWarning, match=''): |
larsoner
approved these changes
Apr 23, 2019
Contributor
|
Thanks @agramfort! |
massich
pushed a commit
to massich/mne-python
that referenced
this pull request
Apr 23, 2019
…mestamps (mne-tools#6184) * DOC: make sure you get a warning when reading onsets which are not timestamps in .csv * non-empty match
jeythekey
pushed a commit
to jeythekey/mne-python
that referenced
this pull request
Apr 27, 2019
…mestamps (mne-tools#6184) * DOC: make sure you get a warning when reading onsets which are not timestamps in .csv * non-empty match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6107