Skip to content

ENH: Add MNE-fsaverage#6174

Merged
agramfort merged 20 commits intomne-tools:masterfrom
massich:fsaverage
Apr 23, 2019
Merged

ENH: Add MNE-fsaverage#6174
agramfort merged 20 commits intomne-tools:masterfrom
massich:fsaverage

Conversation

@massich
Copy link
Copy Markdown
Contributor

@massich massich commented Apr 22, 2019

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 22, 2019

Codecov Report

Merging #6174 into master will decrease coverage by 0.1%.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##           master   #6174      +/-   ##
=========================================
- Coverage      89%   88.9%   -0.11%     
=========================================
  Files         410     412       +2     
  Lines       73885   74152     +267     
  Branches    12256   12311      +55     
=========================================
+ Hits        65765   65924     +159     
- Misses       5224    5333     +109     
+ Partials     2896    2895       -1

@massich massich self-assigned this Apr 22, 2019
@larsoner
Copy link
Copy Markdown
Member

@massich let me know when to look

@agramfort
Copy link
Copy Markdown
Member

you have a valid error : https://travis-ci.org/mne-tools/mne-python/jobs/523233377

@agramfort agramfort merged commit 9cc5d14 into mne-tools:master Apr 23, 2019
@agramfort
Copy link
Copy Markdown
Member

thx @larsoner and @massich !

@massich
Copy link
Copy Markdown
Contributor Author

massich commented Apr 23, 2019

Cool! I'm rebasing the examples!

massich added a commit to massich/mne-python that referenced this pull request Apr 23, 2019
* Keep eric's fsaverage

* make set_montage_coreg_path as private

* stip check manifest out from fsaverage

* ENH: better parameter name

* move the fsaverage info to fsaverage

* FIX: docstring

* [skip ci] move fsaverage files

* rename

* update the fsaverage manifests

* FIX: use the new zip files

* FIX: Fix test

* FIX: manifests

* FIX: Manifest again

* FIX: Doc

* FIX: call montage setter

* ENH: Simplify

* FIX: string

* fix

* Skip the test for 3.5, since zipfiles cannot be written
@massich massich deleted the fsaverage branch April 23, 2019 17:35
jeythekey pushed a commit to jeythekey/mne-python that referenced this pull request Apr 27, 2019
* Keep eric's fsaverage

* make set_montage_coreg_path as private

* stip check manifest out from fsaverage

* ENH: better parameter name

* move the fsaverage info to fsaverage

* FIX: docstring

* [skip ci] move fsaverage files

* rename

* update the fsaverage manifests

* FIX: use the new zip files

* FIX: Fix test

* FIX: manifests

* FIX: Manifest again

* FIX: Doc

* FIX: call montage setter

* ENH: Simplify

* FIX: string

* fix

* Skip the test for 3.5, since zipfiles cannot be written
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants