Skip to content

MAINT: Use version-based permalink for download#6161

Merged
massich merged 3 commits intomne-tools:masterfrom
larsoner:permalink
Apr 17, 2019
Merged

MAINT: Use version-based permalink for download#6161
massich merged 3 commits intomne-tools:masterfrom
larsoner:permalink

Conversation

@larsoner
Copy link
Copy Markdown
Member

@larsoner larsoner commented Apr 17, 2019

If you use just the /download link from OSF, it gets the latest version of the dataset. This is problematic when we update. From now on, updating one of our OSF datasets will require updating the hash and the version number in the URL.

We should avoid updating any of these datasets if possible until we release 0.18 in order to avoid breaking 0.17 users' downloads.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2019 •
edited
Loading

Codecov Report

Merging #6161 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6161   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files         410     410           
  Lines       73834   73834           
  Branches    12250   12250           
======================================
  Hits        65713   65713           
  Misses       5226    5226           
  Partials     2895    2895

@larsoner
Copy link
Copy Markdown
Member Author

larsoner commented Apr 17, 2019

Hmm it looks like the previous version of sample was 1.65 GB, and the new one is 2.52 GB.

@massich usually the updating procedure is to download the original MNE-sample-data freshly, add files to it, recompress, and upload. It looks like you might have just compressed the existing MNE-sample-data directory you have been using for a while, since there are extraneous new files like _sss.fif and -epo.fif files in it.

For now I'll revert the update to this new version, since I think this is not what we want to use.

@massich
Copy link
Copy Markdown
Contributor

massich commented Apr 17, 2019

Yes, I swapped the MNE-sample for the one I was using in my fork. I did not realize that about those files. I've reverted master.

@massich
Copy link
Copy Markdown
Contributor

massich commented Apr 17, 2019

I've restarted the failing builds. And everything is green. MErging.

@massich massich merged commit 2c215d8 into mne-tools:master Apr 17, 2019
@massich massich added the backport-candidate on-merge: backport to maint/1.12 label Apr 17, 2019
@larsoner larsoner deleted the permalink branch April 17, 2019 11:24
@massich massich removed the backport-candidate on-merge: backport to maint/1.12 label Apr 17, 2019
massich pushed a commit to massich/mne-python that referenced this pull request Apr 23, 2019
MAINT: Use version-based permalink for download (mne-tools#6161)
22c2b41
jeythekey pushed a commit to jeythekey/mne-python that referenced this pull request Apr 27, 2019
@larsoner @jeythekey
MAINT: Use version-based permalink for download (mne-tools#6161)
00d180e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@larsoner @massich