MRG: Fix inconsistencies with compute_proj_raw#6160
Merged
larsoner merged 2 commits intomne-tools:masterfrom Apr 17, 2019
Merged
MRG: Fix inconsistencies with compute_proj_raw#6160larsoner merged 2 commits intomne-tools:masterfrom
larsoner merged 2 commits intomne-tools:masterfrom
Conversation
agramfort
approved these changes
Apr 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #6160 +/- ##
=========================================
+ Coverage 89% 89% +<.01%
=========================================
Files 410 410
Lines 73834 73858 +24
Branches 12250 12253 +3
=========================================
+ Hits 65713 65737 +24
Misses 5226 5226
Partials 2895 2895 |
massich
pushed a commit
to massich/mne-python
that referenced
this pull request
Apr 23, 2019
* FIX: Fix inconsistencies with compute_proj_raw * BUG: SciPy req
jeythekey
pushed a commit
to jeythekey/mne-python
that referenced
this pull request
Apr 27, 2019
* FIX: Fix inconsistencies with compute_proj_raw * BUG: SciPy req
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
duration=Noneandduration=1.(default) equivalent when possible. Bugs:baseline=Noneshould have been used in Epochs constructorproj=Falseshould have been used in Epochs constructortmax=duration - 1. / sfreqshould have been used in Epochs constructordurationfor non-integer sample rates