[MINOR] Add evoked GFP to tutorials#5796
Merged
agramfort merged 6 commits intomne-tools:masterfrom Dec 18, 2018
Merged
Conversation
agramfort
reviewed
Dec 17, 2018
Codecov Report
@@ Coverage Diff @@
## master #5796 +/- ##
==========================================
- Coverage 88.55% 88.53% -0.03%
==========================================
Files 369 369
Lines 69139 68955 -184
Branches 11638 11614 -24
==========================================
- Hits 61228 61050 -178
Misses 5046 5046
+ Partials 2865 2859 -6 |
Member
|
I modernized the |
mmagnuski
reviewed
Dec 17, 2018
| # standard deviation across channels, here shown just for EEG. | ||
|
|
||
| gfp = evoked.copy().pick_types(eeg=True, meg=False).data.std(axis=0) | ||
| fig, ax = plt.subplots(1) |
Member
|
+1 for MRG |
Contributor
Author
jona-sassenhagen
left a comment
There was a problem hiding this comment.
Looks good - I guess will merge myself, as Eric wrote half the code at this stage :)
Contributor
Author
|
Ah I forgot the scaling. Good like this? |
Contributor
|
a bit off topic question: Shall we add the definition of global field power (GFP) to the glossary? and link to it? Does anyone see value to that? or all users know the terms enought that is not worth the effort? |
Contributor
Author
|
No, that makes sense to me. You can do it directly on this PR?
…________________________________
From: Joan Massich <notifications@github.com>
Sent: Tuesday, December 18, 2018 10:36 AM
To: mne-tools/mne-python
Cc: jona-sassenhagen; Mention
Subject: Re: [mne-tools/mne-python] [MINOR] Add evoked GFP to tutorials (#5796)
a bit off topic question: Shall we add the definition of global field power (GFP) to the glossary? and link to it?
Does anyone see value to that? or all users know the terms enought that is not worth the effort?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#5796 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEHyItyrne8s6POa3YWXcBgdfskg9BpVks5u6LczgaJpZM4ZWRYF>.
|
agramfort
reviewed
Dec 18, 2018
| import os.path as op | ||
|
|
||
| import mne | ||
| import matplotlib.pyplot as plt |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few lines to the evoked object tutorial to show how to extract and plot the SD across channels, as discussed in #4002
I'm trying to close old issues :)
Closes #4002