Fix: nearly invisible traces with spatial_colors=True#13286
Fix: nearly invisible traces with spatial_colors=True#13286larsoner merged 7 commits intomne-tools:mainfrom
Conversation
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
for more information, see https://pre-commit.ci
|
Can you add a And then can you make some trivial change to https://github.com/mne-tools/mne-python/blob/main/tutorials/evoked/20_visualize_evoked.py ? Any trivial change should work (e.g., changing whitespace) as it will make CircleCI rerender the example so we can see if it changes |
for more information, see https://pre-commit.ci
|
thanks for your patience! I’ve pushed the updates. |
for more information, see https://pre-commit.ci
|
One more thing from above ☝️
|
|
sorry for that. I've pushed another update |
|
I looked at the example and the images didn't change, which I guess is okay since none of those were really invisible. Adapting the example from one of the issues above: I do see one channel that was hard to see get a bit darker
In the future we might consider using some other smoother transformation of all lightness values (like a sigmoid or even just a linear rescaling) rather than a threshold-based one since this one could lead to color collisions but this already seems like a usability improvement. So I think this is good to go, marking for merge-when-green, thanks in advance @Mojackhak ! |
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
|
Thanks for double-checking and merging! 🙌 |
* upstream/main: (55 commits) doc: fix rendering typo rst docstr (mne-tools#13301) DOC: fix docstrs around layout functions (mne-tools#13300) MAINT: Fix doc build failure due to deprecation (mne-tools#13299) Birthday input cast to datetime.date (mne-tools#13284) DOC: fix missing space, use f-strings, structure->object (mne-tools#13291) [pre-commit.ci] pre-commit autoupdate (mne-tools#13290) ENH: channel_indices_by_type now has an exclude param (mne-tools#13293) Proj id and proj name access (mne-tools#13261) Fix: nearly invisible traces with spatial_colors=True (mne-tools#13286) [pre-commit.ci] pre-commit autoupdate (mne-tools#13283) Bump autofix-ci/action from 551dded8c6cc8a1054039c8bc0b8b48c51dfc6ef to 635ffb0c9798bd160680f18fd73371e355b85f27 in the actions group (mne-tools#13282) fix Maxwell bads filtering (mne-tools#13280) fix actionable linkcheck errors (mne-tools#13273) MAINT: Use radius keyword with PyVista tube (mne-tools#13277) BUG: Fix bug with simulating head pos and BEM (mne-tools#13276) [pre-commit.ci] pre-commit autoupdate (mne-tools#13274) MAINT: Update code credit (mne-tools#13267) Annotations extras (mne-tools#13228) Tidy up the directory reading (mne-tools#13268) FIX, DOC: Drop bad channel in 10_publication_figure.py (mne-tools#13266) ...
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>


Reference issue (if any)
Fixes #6686
Fixes #13285
What does this implement/fix?
This patch modifies the
_rgbfunction inmne/viz/evoked.pyto reduce the intensity of overly light RGB colors that can occur whenspatial_colors=Trueis used in PSD plots. Specifically, it checks whether the sum of RGB components is above a threshold (2.5) and reduces the brightness to improve trace visibility.This issue was previously discussed in Discourse thread #6572, and this fix follows the workaround suggested by @bboyth, which has been confirmed to work in MNE 1.9.0 by multiple users.
Additional information
None