FIX: Parallel build JSON file issues #13241
Merged
larsoner merged 20 commits intomne-tools:mainfrom May 21, 2025
Merged
Conversation
Member
|
CI failure looks related:
Details
|
Contributor
Author
|
Super related. Looks like another test is using the tmp folder that I defined and putting some variables to mne.json that i defined. I solved this. 'MNE_STIM_CHANNEL': 'STI 014', 'SUBJECTS_DIR': 'C:\Users\VssAdministrator\AppData\Local\Temp\pytest-of-VssAdministrator\pytest-0\test_datasets_basic0\mne_data\MNE-fsaverage-data', 'MNE_LOGGING_LEVEL': 'warning', 'MNE_FORCE_SERIAL': 'true'} |
Contributor
Author
|
I changed the logic, now we check the complementary set. Should be more robust in case the keys are already present in the mne configuration. I had the impression that CI is running with some parallelisation at the test level (i.e, multiple tests running in parallel), but I am not sure. |
Contributor
Author
|
Hey guys @agramfort, @larsoner and @drammock, I think it okay for me now... I just need the confirmation with the tests, but i need the workflows approval to be able to check. |
larsoner
reviewed
May 13, 2025
Member
|
... one last thing, to fully fix the referenced issue, we'll want to filelock the forward dot product calc code, too mne-python/mne/forward/_lead_dots.py Line 53 in 266ccc9 So we should add that here, or remove the "fixes" tag in the top comment |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
bruAristimunha
commented
May 13, 2025
Contributor
Author
Good catch, thank you for pointing. I forgot. Should work now. |
larsoner
reviewed
May 15, 2025
larsoner
approved these changes
May 15, 2025
Member
larsoner
left a comment
There was a problem hiding this comment.
Just one tiny tweak to make the logger.info more informative, committed and marking for merge-when-green, thanks in advance @bruAristimunha !
Contributor
Author
|
The CI issue doesnt seems related @larsoner |
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
Member
|
Thanks @bruAristimunha ! |
larsoner
added a commit
that referenced
this pull request
May 22, 2025
…e-config * upstream/main: FIX: Parallel build JSON file issues (#13241)
zEdS15B3GCwq
pushed a commit
to zEdS15B3GCwq/mne-python
that referenced
this pull request
Aug 25, 2025
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13139.
What does this implement/fix?
Implementing a small semaphore to ensure we are always writing mne config json correctly even if we have parallel file access. Using filelock as optional dependency.
Additional information
This is affect moabb and braindecode a lot.