Correct typo in SSD documentation#12924
Merged
larsoner merged 7 commits intomne-tools:mainfrom Oct 30, 2024
SHEscher:main
Merged
Correct typo in SSD documentation#12924larsoner merged 7 commits intomne-tools:mainfrom SHEscher:main
larsoner merged 7 commits intomne-tools:mainfrom
SHEscher:main
Conversation
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
drammock
approved these changes
Oct 29, 2024
Member
drammock
left a comment
There was a problem hiding this comment.
LGTM. Could you add a changelog entry doc/changes/devel/12942.bugfix.rst please? You can find other *bugfix.rst examples in that folder, but the basic format is
Fix typos in the Spatio-Spectral Decomposition example, by `Your Name`_.
You'll also need to add your name and URL to doc/changes/names.inc (alphabetically please)
Member
|
For a new contributor this is a bit better! |
for more information, see https://pre-commit.ci
Contributor
Author
|
Hey, I amended the former commit, adding the requested files and lines. |
drammock
reviewed
Oct 30, 2024
Member
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #12807.
What does this implement/fix?
Additional information
I have been asked by @larsoner to submit this PR.