Merged
Conversation
Member
|
I opened SeleniumHQ/selenium#14687 about the selenium warning |
Member
Author
|
Failing successfully! 
Will push a commit to fix the sklearn errors |
Member
Author
|
Ugghhhh actually that was a timeout, need to increase the limit to make sure it actually fails |
Member
Author
|
Okay now we're good!
Pushing a fix for sklearn and marking for merge-when-green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couldn't figure out why only the Azure pip-pre was failing, it was because
continue-on-error: truewas set which means the failed test in pip-pre was ignored because thecodecovstep after it succeeded 😬Also the doc build is failing because of a new deprecation warning in selenium.
I expect this to fail with a sklearn error in the Linux pip-pre job. Once it does, I'll push a fix for that, then self-merge if it's trivial.