BUG: Fix bug with minimum phase filters#12507
Merged
drammock merged 6 commits intomne-tools:mainfrom Mar 19, 2024
Merged
Conversation
drammock
reviewed
Mar 19, 2024
doc/changes/devel/12507.bugfix.rst
Outdated
Comment on lines
+3
to
+4
| compromised attenuation. Now ``phase="minimum"`` has the same length and comparable | ||
| suppression as ``phase="minimum"``, and the old (incorrect) behavior can be achieved |
Member
There was a problem hiding this comment.
Suggested change
| compromised attenuation. Now ``phase="minimum"`` has the same length and comparable | |
| suppression as ``phase="minimum"``, and the old (incorrect) behavior can be achieved | |
| compromised attenuation. Now ``phase="minimum"`` has the same length and comparable | |
| suppression as ``phase="zero"``, and the old (incorrect) behavior can be achieved |
tautology; I think this is the right repair but @larsoner please confirm
Comment on lines
+324
to
+328
| # that the falloff is not as steep (though here we use a temporary workaround | ||
| # version vendored by MNE until https://github.com/scipy/scipy/pull/19706 is | ||
| # merged and released): | ||
|
|
||
| h_min = signal.minimum_phase(h) | ||
| h_min = minimum_phase(h, half=False) |
Member
There was a problem hiding this comment.
not sure we want to talk about "vendoring" in our tutorials. Seems like a detail users shouldn't need to know about. Maybe instead just mention which SciPy / MNE versions & params are necessary to get the correct behavior?
Member
Author
|
Fixed, can you see if the wording is good enough now @drammock ? |
drammock
reviewed
Mar 19, 2024
Co-authored-by: Daniel McCloy <dan@mccloy.info>
drammock
approved these changes
Mar 19, 2024
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel McCloy <dan@mccloy.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12267
No need to wait for the SciPy PR I think since the tests there (and here, including the updated tutorial) show this works correctly.