Merged
Conversation
drammock
approved these changes
Mar 5, 2024
Member
|
LGTM but I'll wait to merge until @cbrnr has a chance to look |
Contributor
|
Like I said in the other PR, I can test this in a couple of days. Thanks a lot for working on this! |
Contributor
|
Thanks @larsoner! |
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See mne-tools/mne-qt-browser#233 (comment), but in short:
Setting the global
QIcon.setThemeSearchPathsto only our path is not compatible with other bits of software like mne-qt-browser and MNELABInstead, prepend our path
When calling
QIcon.fromTheme, ask for the correct icon name but also provide a fallback in case the user has switched to a theme name that does not provide the correct icons. In MNE-Qt-browser and MNE we provide support for "light" and "dark" and I checked to make sure these work concurrently (they seem to at least!)@cbrnr feel free to see if this helps with MNELAB