fix merge_asof usage in read_raw_eyelink()#12481
Merged
larsoner merged 2 commits intomne-tools:mainfrom Mar 5, 2024
Merged
Conversation
Contributor
|
Thanks again! - I haven't looked at the code yet, but if |
Member
|
Thanks @dominikwelke |
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #12480
the new parameter set is also not perfect:
direction=nearestcan lead to duplicating samples (as a sample on an uneven ms is equally distanced to the previous and subsequent millisecond). you can see this behavior running the simplified example code in the issue.but i think this is better than
forward/backwardwhich does not duplicate samples, but works worse with sfreqs < 500 Hz, as it can shift samples in the wrong direction