Make ECoG and sEEG size defaults more realistic#12474
Make ECoG and sEEG size defaults more realistic#12474drammock merged 6 commits intomne-tools:mainfrom
Conversation
|
@alexrockhill ok for you? |
If not, I can also go back to implementation (2) in issue #12472 and just have it as an option to pass electrode size instead. Thanks for any thoughts you have! |
|
both would work for me but maybe a better default is enough?
… Message ID: ***@***.***>
|
|
Looks like a good default size to me! Glad you're using this @libertyh! |
|
never mind, I see you already did! I was misled by the failing changelog test, will have to see why that's happening. |
Co-authored-by: Daniel McCloy <dan@mccloy.info>
|
test failures are unrelated --- we're testing against pre-release of NumPy 2.0 which has some API changes, and a dependency (pandas) hasn't yet accomodated. So I'll go ahead and merge; thanks @libertyh! |
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Reference issue
Fixes issue #12472
What does this implement/fix?
Makes a minor change to the ECoG and sEEG default electrode sizes in
defaults.pyso they are more realistic (2e-3instead of5e-3). This makes it so sEEG and ECoG electrodes do not overlap one another and better reflect the actual size of electrodes in real devices.Additional information
The original size was
5e-3and new size is2e-3. This reflects a 2mm contact size, which is closer to the typical 0.8-2.5 mm contact sizes for ECoG and sEEG. This also means that electrodes with spacing <5mm (which is quite typical) will not overlap in the visualizations.