Fixes for #12360 Replacing percent format with f-strings by hasrat17 · Pull Request #12464 · mne-tools/mne-python

hasrat17 · 2024-02-26T21:29:26Z

Reference issue

FIXES #12360

What does this implement/fix?

Replace percent format with format specifiers (f-strings)

Additional information

Used this command to capture percent format ruff check mne --config pyproject.toml --select UP031

…'ruff check mne --config pyproject.toml --select UP031'

welcome · 2024-02-26T21:29:29Z

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴

hoechenberger · 2024-02-27T08:52:24Z

Thanks for your contribution, @hasrat17! There are numerous tests failing; this would need to be resolved before we can proceed here. Thanks!

hasrat17 · 2024-02-27T18:05:57Z

Hey @hoechenberger, This is my first contribution to open source; sorry for asking this, but can you please correct me if I am wrong? So I need to run this command pytest -m "not ultraslowtest" mne and check whether everything is passing. And the test case here, which is failing like this one, Tests / ubuntu-latest / pip-pre / 3.11 (pull_request) in details shows an extensive file, how to track the error from there to resolve it.

hoechenberger · 2024-02-28T10:01:44Z

Hello, I won't have time to assist you here, sorry. But I'm sure some of the other developers will chime in 👍

larsoner

I gave a couple of hints, can you see if it can help you fix the rest of the errors?

mne/utils/check.py

mne/label.py

Some fixes are done in doc

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

for more information, see https://pre-commit.ci

hasrat17 · 2024-03-19T04:36:46Z

Hey, @cbrnr @drammock @larsoner I have updated everything based on your suggestions. Can we merge this request?

larsoner

Just pushed a tiny commit to revert two little things, marking for merge when green, thanks in advance @hasrat17 !

welcome · 2024-03-19T16:30:54Z

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

…e-tools#12464) Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com> Co-authored-by: Daniel McCloy <dan@mccloy.info> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric Larson <larson.eric.d@gmail.com>

hasrat17 added 4 commits February 25, 2024 02:37

Fixed f string format in epochs.py and fixes.py

2c28a89

Some more fixes for f string

bde07a0

Completed converting % to f string, Now zero result showing for this …

aa8e220

…'ruff check mne --config pyproject.toml --select UP031'

Merge remote-tracking branch 'upstream/main'

73d369a

hasrat17 requested review from adam2392, agramfort, alexrockhill, cbrnr, dengemann, drammock, hoechenberger, jasmainak, larsoner, mscheltienne, rob-luke, sappelhoff and wmvanvliet as code owners February 26, 2024 21:29

larsoner reviewed Feb 28, 2024

View reviewed changes

mne/utils/check.py Outdated Show resolved Hide resolved

mne/label.py Outdated Show resolved Hide resolved

hasrat17 added 5 commits March 1, 2024 00:14

Merge remote-tracking branch 'upstream/main'

5106c2c

More fixes for fstring in label.py, misc.py, check.py

b190e54

Fix one error related to f string

13a130f

Fix fstring issue

454c040

Merge branch 'main' into new_branch

2028c65

Some fixes are done in doc

hasrat17 closed this Mar 2, 2024

hasrat17 force-pushed the main branch from 430952a to 64901c4 Compare March 2, 2024 19:58

hasrat17 reopened this Mar 2, 2024

hasrat17 and others added 21 commits March 13, 2024 23:19

Update mne/io/base.py

3df0d6d

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/io/ctf/info.py

96473d9

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/utils/_testing.py

ff449dc

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/time_frequency/tfr.py

0d9f67b

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/time_frequency/_stockwell.py

d4ebdba

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/io/eyelink/tests/test_eyelink.py

5de4621

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/io/fieldtrip/utils.py

b0d3a71

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/io/kit/coreg.py

601bc0e

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/io/kit/coreg.py

a963fa1

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/label.py

c191822

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/label.py

63dc4c1

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/minimum_norm/time_frequency.py

1ff85cb

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/morph.py

c7cea63

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/preprocessing/artifact_detection.py

82d60dd

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/source_estimate.py

5099829

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/source_estimate.py

d2909e2

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/source_space/_source_space.py

c81d645

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

Update mne/stats/cluster_level.py

e725efb

Co-authored-by: Clemens Brunner <clemens.brunner@gmail.com>

updated mne/simulation/source.py, git_archival

448088a

Merge branch 'main' of https://github.com/hasrat17/mne-python

9d50ba4

[pre-commit.ci] auto fixes from pre-commit.com hooks

4462cd1

for more information, see https://pre-commit.ci

larsoner added this to the 1.7 milestone Mar 14, 2024

hasrat17 requested a review from cbrnr March 16, 2024 08:38

FIX: Minor reverts

a17a905

larsoner approved these changes Mar 19, 2024

View reviewed changes

larsoner merged commit b8d9c17 into mne-tools:main Mar 19, 2024

sappelhoff mentioned this pull request Jul 27, 2024

[MRG] convert some more % strings to fstrings #12758

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixes for #12360 Replacing percent format with f-strings#12464

Fixes for #12360 Replacing percent format with f-strings#12464
larsoner merged 48 commits intomne-tools:mainfrom
hasrat17:main

hasrat17 commented Feb 26, 2024

Uh oh!

welcome bot commented Feb 26, 2024

Uh oh!

hoechenberger commented Feb 27, 2024

Uh oh!

hasrat17 commented Feb 27, 2024

Uh oh!

hoechenberger commented Feb 28, 2024

Uh oh!

larsoner left a comment

Uh oh!

Uh oh!

Uh oh!

hasrat17 commented Mar 19, 2024

Uh oh!

larsoner left a comment

Uh oh!

welcome bot commented Mar 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

hasrat17 commented Feb 26, 2024

Reference issue

What does this implement/fix?

Additional information

Uh oh!

welcome bot commented Feb 26, 2024

Uh oh!

hoechenberger commented Feb 27, 2024

Uh oh!

hasrat17 commented Feb 27, 2024

Uh oh!

hoechenberger commented Feb 28, 2024

Uh oh!

larsoner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hasrat17 commented Mar 19, 2024

Uh oh!

larsoner left a comment

Choose a reason for hiding this comment

Uh oh!

welcome bot commented Mar 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants