BUG: Fix bug with report CSS#12399
Merged
larsoner merged 3 commits intomne-tools:mainfrom Jan 30, 2024
Merged
Conversation
drammock
approved these changes
Jan 30, 2024
Member
drammock
left a comment
There was a problem hiding this comment.
just one question otherwise LGTM
Comment on lines
+14
to
+18
| padding-bottom: 8rem; | ||
| } | ||
|
|
||
| footer { | ||
| margin-top: 8rem; |
Member
There was a problem hiding this comment.
just checking: was it intentional to switch from 5 to 8 here? the .sass file had #toc.padding-bottom: 5rem and footer.margin-top: 5rem
Member
Author
There was a problem hiding this comment.
Yeah 5 was not enough, 8 was determined empirically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12397
Looks like the bug was the use of a
.sassfile (withsasssyntax) but embedding as CSS. Let's keep it simple and stick to vanilla CSS like we do everywhere else. Note the nav bar omitting several items at the end, plus the error in the#tocin the inspector onmainfixed by the PR:Also removes two cruft files from
mne/htmlthat aren't used anymore according togit grep "d3\.v3"andgit grep mpld3for example. Not touching theReporttutorial since it doesn't show the problem (not enough TOC entries).