minimum/maximum value of the all-positive/negative data#12383
minimum/maximum value of the all-positive/negative data#12383larsoner merged 12 commits intomne-tools:mainfrom
Conversation
for more information, see https://pre-commit.ci
mne/evoked.py
Outdated
| tmax : float | None | ||
| The maximum point in time to be considered for peak getting. | ||
| mode : {'pos', 'neg', 'abs'} | ||
| mode : {'pos', 'neg', 'abs', 'min', 'max'} |
There was a problem hiding this comment.
confused; this doesn't match the API in the PR description (as was discussed in #12381)
There was a problem hiding this comment.
Sorry about that! I didn't push my changes yet.
|
I see that you've marked this as |
Okay, thanks for letting me know! I'll be sure to do that next time. Github should let people set up a grace period for notifications. It probably wastes a lot of maintainers' time. |
for more information, see https://pre-commit.ci
…e-python into pr/withmywoessner/12383
for more information, see https://pre-commit.ci
…e-python into pr/withmywoessner/12383
larsoner
left a comment
There was a problem hiding this comment.
Seems reasonable to me, just some minor stuff
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
for more information, see https://pre-commit.ci
|
Done! @larsoner Thank you |
|
@larsoner I let you merge if happy |
|
Thanks @withmywoessner ! |
Reference issue
#12381
What does this implement/fix?
Currently,
evoked.get_peak()can't find a min/max in all positive/ all negative data.Implementation:
evoked.get_peak(mode="neg", strict=False)strictdetermines whether to return error if mode="neg" and there are no negative values (the current behavior, would become the strict=True behavior), or instead to return the minimum value of the all-positive data (the strict=False behavior).