fix section parameter to allow proper hierarchy#12319
Merged
drammock merged 3 commits intomne-tools:mainfrom Dec 21, 2023
Merged
fix section parameter to allow proper hierarchy#12319drammock merged 3 commits intomne-tools:mainfrom
drammock merged 3 commits intomne-tools:mainfrom
Conversation
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
Member
|
@obergmartin could you add a |
Contributor
Author
|
@larsoner glad to be a contributor, looking forward to doing more! |
drammock
approved these changes
Dec 21, 2023
Member
drammock
left a comment
There was a problem hiding this comment.
tested locally and it works for me. Thanks @obergmartin
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Discussion on Discourse about Report.add_html().
HTML chunks were added to the main level, not within the supplied
section.The section value passed to
self._add_or_replacewas hard coded asNoneand didn't use the supplied section argument.