Switch from epoch_data to data for TFR array functions#12308
Merged
larsoner merged 4 commits intomne-tools:mainfrom Dec 19, 2023
Merged
Switch from epoch_data to data for TFR array functions#12308larsoner merged 4 commits intomne-tools:mainfrom
epoch_data to data for TFR array functions#12308larsoner merged 4 commits intomne-tools:mainfrom
Conversation
Member
|
Hello @tsbinns, could you add a changelog entry, please? Thank you! |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Dec 20, 2023
* upstream/main: BUG: handle temporal discontinuities in Neuralynx `.ncs` files (mne-tools#12279) MAINT: Work around bad SciPy nightly wheels (mne-tools#12317) fix 404 link on devel landing page (mne-tools#12316) Switch from `epoch_data` to `data` for TFR array functions (mne-tools#12308) [pre-commit.ci] pre-commit autoupdate (mne-tools#12307) fix icon link colors (mne-tools#12301) Bump actions/download-artifact from 3 to 4 (mne-tools#12304) Bump github/codeql-action from 2 to 3 (mne-tools#12303) Bump actions/upload-artifact from 3 to 4 (mne-tools#12302)
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #12305.
As discussed, I have just switched the
epoch_dataparameter for thetfr_array_morletandtfr_array_multitaperfunctions todata, and have added aFutureWarningifepoch_data is not None.The
_compute_tfrfunction which is called internally has theepoch_dataparameter, but I haven't touched that here.mne-python/mne/time_frequency/tfr.py
Lines 417 to 431 in b1dd84c