MAINT: Replace Path.parent.parent with Path.parents[N] in tests#12257
Merged
hoechenberger merged 2 commits intomne-tools:mainfrom Dec 5, 2023
Merged
MAINT: Replace Path.parent.parent with Path.parents[N] in tests#12257hoechenberger merged 2 commits intomne-tools:mainfrom
Path.parent.parent with Path.parents[N] in tests#12257hoechenberger merged 2 commits intomne-tools:mainfrom
Conversation
larsoner
added a commit
to hoechenberger/mne-python
that referenced
this pull request
Dec 5, 2023
* upstream/main: MRG: Use ruff-format instead of Black (mne-tools#12261) MAINT: Make selenium optional and use on CircleCI (mne-tools#12263) MAINT: Post-release deprecations (mne-tools#12265) MAINT: Replace `Path.parent.parent` with `Path.parents[N]` in tests (mne-tools#12257)
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #12183.
What does this implement/fix?
This PR replaces all
Path.parent.parentandPath.parent.parent.parentcalls in test files withPath.parents[1]andPath.parents[2], respectively.Additional information
I hope that it's fine that I did not ask whether the issue is still up for grabs (found no PR addressing it already).