[MRG] DOC: inform about channel discrepancy in make_lcmv#12238
[MRG] DOC: inform about channel discrepancy in make_lcmv#12238larsoner merged 7 commits intomne-tools:mainfrom
Conversation
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
0b10a0b to
4790bfb
Compare
4790bfb to
2ff25a2
Compare
larsoner
left a comment
There was a problem hiding this comment.
Thanks for looking into this! Just a minor suggestion to improve the message. Can you also add an entry to doc/changes/devel.rst using the :newcontrib: role to mention your enhancement?
|
Thanks for the review @larsoner! I fixed the points you mentioned.
Feel free to suggest any other changes if needed. |
larsoner
left a comment
There was a problem hiding this comment.
The new logger message is there but gets shown twice since _check_info_inv is currently called twice (once through _check_one_ch_type and once explicitly).
One solution to this is to:
- Add the
@verbosedecorator to_check_info_inv - Add
verbose=Noneto the signature - Inside
_check_one_ch_type, call `_check_info_inv(..., erbose=_verbose_safe_false())
This will make it so that the message only shows up once, because it won't be shown in the _check_one_ch_type is called.
|
@ctrltz you have a conflict, and merging in |
|
Thanks for the help and sorry for the delayed reply @larsoner! Your idea with |
|
I've updated the PR, it should be ready for merge now. The logger message is shown only once now, and failing CI checks are not related to the PR. |
Reference issue
Fixes #10918.
What does this implement/fix?
This PR adds a
logger.infomessage if some channels apart from bads and reference had to be dropped duringmake_lcmvto ensure thatforward,data_cov, andnoise_covhave the same set of channels.