Skip to content

BUG: Fix bug with get_view#12000

Merged
larsoner merged 11 commits intomne-tools:mainfrom
larsoner:view
Sep 20, 2023
Merged

BUG: Fix bug with get_view#12000
larsoner merged 11 commits intomne-tools:mainfrom
larsoner:view

Conversation

@larsoner
Copy link
Copy Markdown
Member

@larsoner larsoner commented Sep 18, 2023

Not done but some progress has been made at least.

Closes #11189
Closes #11941

@larsoner larsoner marked this pull request as ready for review September 19, 2023 16:41
@larsoner
Copy link
Copy Markdown
Member Author

Okay think I finally fixed all the bugs. @wmvanvliet feel free to review and merge if you're happy. It's not perfect -- arrow keys when you're viewing the brain from above / axial view are imperfect -- but it's much better than on main I think and we can improve that part later.

@wmvanvliet
Copy link
Copy Markdown
Contributor

Camera behavior is much better now! Much appreciated.

* upstream/main:
  Interactive version of plot_evoked_fieldmap (mne-tools#11942)
  ENH: Add support for Artinis SNIRF data (mne-tools#11926)
@larsoner larsoner enabled auto-merge (squash) September 20, 2023 14:08
@larsoner larsoner merged commit 77ba263 into mne-tools:main Sep 20, 2023
@larsoner larsoner deleted the view branch September 20, 2023 15:17
larsoner added a commit to wmvanvliet/mne-python that referenced this pull request Sep 20, 2023
snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: brain.set_view(**brain.get_view()) not no-op get_view does not report correct camera position

3 participants