Skip to content

Deprecate complex spectrum obj#11978

Merged
larsoner merged 6 commits intomne-tools:mainfrom
drammock:deprecate-complex-spectrum-obj
Sep 11, 2023
Merged

Deprecate complex spectrum obj#11978
larsoner merged 6 commits intomne-tools:mainfrom
drammock:deprecate-complex-spectrum-obj

Conversation

@drammock
Copy link
Copy Markdown
Member

following discussion in #11803 (summarized in this comment) this deprecates support for complex output in Spectrum and EpochsSpectrum objects.

@larsoner
Copy link
Copy Markdown
Member

One possible real-world use case might be in computing connectivity estimates where you want to work with complex-valued spectra per taper, compute connectivity on each taper, then average those estimates or so. But from a very quick look I don't think mne-connectivity uses these so I think it's okay to deprecate 👍

@drammock
Copy link
Copy Markdown
Member Author

One possible real-world use case might be in computing connectivity estimates where you want to work with complex-valued spectra per taper, compute connectivity on each taper, then average those estimates or so. But from a very quick look I don't think mne-connectivity uses these so I think it's okay to deprecate 👍

that is still supported, as long as you're willing to use the psd_array_* functions and munge the output as needed. Feel free to convert your comment into an issue if you think we should have an example/tutorial to demo that workflow.

drammock and others added 2 commits September 11, 2023 09:15
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
@drammock drammock requested a review from cbrnr as a code owner September 11, 2023 14:20
@larsoner larsoner merged commit 89d10ff into mne-tools:main Sep 11, 2023
@larsoner
Copy link
Copy Markdown
Member

Thanks @drammock !

@drammock drammock deleted the deprecate-complex-spectrum-obj branch January 2, 2024 19:43
snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants