FIX: Missing Saccade information in Eyelink File#11877
Merged
larsoner merged 3 commits intomne-tools:mainfrom Aug 14, 2023
Merged
FIX: Missing Saccade information in Eyelink File#11877larsoner merged 3 commits intomne-tools:mainfrom
larsoner merged 3 commits intomne-tools:mainfrom
Conversation
I have a file where participant was in the middle of a saccade at recording start. Thus the ESACC i.e. end saccade event had missing values, ".", that needed to be properly converted to nans during dataframe handling.
in the simulated test file, I added a case where there are missing values in the ESACC events so that we can test for this edge case in the CI
larsoner
approved these changes
Aug 14, 2023
Member
larsoner
left a comment
There was a problem hiding this comment.
Looks good, and yes simulating (or even copying-to-tmp_path-and-editing an existing) file is preferred for small stuff like this. If we added new test files for every tiny corner case we had for every reader our testing data would get way too big... so the smaller we can keep it with changes like what you have here, the better!
Member
|
... marking for merge-when-green and will merge |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Aug 15, 2023
* upstream/main: Refactor test_epochs.py::test_split_saving (1 out of 2) (mne-tools#11880) FIX: Missing Saccade information in Eyelink File (mne-tools#11877) Improve drawing of annotations with matplotlib (mne-tools#11855) MAINT: Work around NumPy deprecation (mne-tools#11878)
larsoner
added a commit
to drammock/mne-python
that referenced
this pull request
Aug 22, 2023
* upstream/main: [pre-commit.ci] pre-commit autoupdate (mne-tools#11911) [BUG, MRG] Remove check on `mne.viz.Brain.add_volume_labels` (mne-tools#11889) Small splits fix (mne-tools#11905) adds niseq package to "Related software" (mne-tools#11909) Minor fixes for ERDS maps example (mne-tools#11904) FIX: Fix pyvista rendering (mne-tools#11896) BUG: Fix epoch splits naming (mne-tools#11876) ENH: Use section-title for HTML anchors in Report (mne-tools#11890) CI: Deploy [circle deploy] MAINT: Clean up whats_new and doc versions (mne-tools#11888) Refactor test_epochs.py::test_split_saving (2 out of 2) (mne-tools#11884) Cross-figure event passing system (mne-tools#11685) MAINT: Post-release deprecations, updates [circle deploy] (mne-tools#11887) MAINT: Release 1.5.0 (mne-tools#11886) [pre-commit.ci] pre-commit autoupdate (mne-tools#11883) Refactor test_epochs.py::test_split_saving (1 out of 2) (mne-tools#11880) FIX: Missing Saccade information in Eyelink File (mne-tools#11877) Improve drawing of annotations with matplotlib (mne-tools#11855) MAINT: Work around NumPy deprecation (mne-tools#11878)
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an issue as PR.
I hit an edge case in one of my Eyelink files, where the participant was in the middle of a saccade upon recording start. This edge case results in missing values (i.e. ".") in the "ESACC" event of the ASCII file, that need to be properly converted to nans during reading.
it was a quick fix, and I added a line to the test suite to simulate this edge case, but Let me know if you want me to share a file and code to reproduce the error, or if you need more info.