Conversation
larsoner
left a comment
There was a problem hiding this comment.
Looks pretty straightforward and stays readable, nice!
|
so basically a 2x difference? @drammock did you sort out the issue of scipy module if we don't nest the imports? |
I'm not totally sure what this refers to... but my expectation is that this |
|
That's what I expect too @larsoner. I got partway through the unnesting work and will finish it tomorrow and push the results |
|
IIUC the |
* upstream/main: MAINT: Move underscores (mne-tools#11914)
* upstream/main: BUG: Fix bug with snirf birthday (mne-tools#11912)
mne/utils/__init__.py
Outdated
| # # # WARNING # # # | ||
| # This list must also be updated in doc/_templates/autosummary/class.rst if it | ||
| # is changed here! |
There was a problem hiding this comment.
isn't this comment now cruft?
|
Thanks @drammock I'll push a commit with those fixes soon |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
This reverts commit dea8f87.
Proof of concept for adopting SPEC 1.
~380 ms on
main:~205 ms on this PR after only converting
mne/__init__.py(i.e. all the other__init__files unchanged):Todo:
EAGER_IMPORT=trueenv var to smoke out circular import issues__init__.pyEAGER_IMPORT=true)mne/io/__init__.pyand convertmne/fiff/__init__.py