[BUG, MRG] Fix topomap extra plot generated, add util to check a range#11607
Merged
larsoner merged 5 commits intomne-tools:mainfrom Mar 28, 2023
Merged
[BUG, MRG] Fix topomap extra plot generated, add util to check a range#11607larsoner merged 5 commits intomne-tools:mainfrom
larsoner merged 5 commits intomne-tools:mainfrom
Conversation
Contributor
Author
|
Once this is merged, then it will be possible to get the CIs for mne-tools/mne-gui-addons#3 green @larsoner Should be good to go. |
Member
|
You reverted some recent changes here |
Contributor
Author
|
Ah shoot, my bad, fixing now |
Contributor
Author
|
Okay to merge @larsoner? |
drammock
reviewed
Mar 28, 2023
Member
drammock
left a comment
There was a problem hiding this comment.
why the addition of _check_range here? In the diff it's only being used in a test, which seems to be unrelated to the principal change (a change from plt.subplots_adjust to Figure.subplots_adjust)
Contributor
Author
|
They're both things necessary for the GUI code. They could be in two separate PRs, they are unrelated but since the |
Member
|
Thanks @alexrockhill ! |
larsoner
added a commit
to cbrnr/mne-python
that referenced
this pull request
Apr 21, 2023
* upstream/main: (50 commits) BUG: Fix bug with paths (mne-tools#11639) MAINT: Report download time and size (mne-tools#11635) MRG: Allow retrieval of channel names via make_1020_channel_selections() (mne-tools#11632) Fix index name in to_data_frame()'s docstring (mne-tools#11457) MAINT: Use VTK prerelease wheels in pre jobs (mne-tools#11629) ENH: Allow gradient compensated data in maxwell_filter (mne-tools#10554) make test compatible with future pandas (mne-tools#11625) Display SVG figures correctly in Report (mne-tools#11623) API: Port ieeg gui over to mne-gui-addons and add tfr gui example (mne-tools#11616) MAINT: Add token [ci skip] (mne-tools#11622) API: One cycle of backward compat (mne-tools#11621) MAINT: Use git rather than zipball (mne-tools#11620) ENH: Speed up code a bit (mne-tools#11614) [BUG, MRG] Don't modify info in place for transform points (mne-tools#11612) [BUG, MRG] Fix topomap extra plot generated, add util to check a range (mne-tools#11607) ENH: Add mne-bids-pipeline to mne sys_info (mne-tools#11606) MAINT: `coding: utf-8` is implicit in Python 3 (mne-tools#11599) ENH: Read eyetracking data (Eyelink) (Fork of mne-tools#10855 ) (mne-tools#11152) MAINT: In Python 3, do not prefix literals with `u` (mne-tools#11604) MAINT: object is an implicit base for all classes (mne-tools#11601) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the extra topomap plot and adds a check range function so that they can be used in the separate repo version of #11352.