Slightly rework mne.sys_info()
#11568
Conversation
larsoner
left a comment
There was a problem hiding this comment.
Looks good to me! But feel free to reorganize categories + headers if you're motivated to follow @drammock's suggestion in the PR (I thought the headers were nice). Also aesthetically I liked the change to parens instead of the braces for the extra info for NumPy/qtpy/PyVista if you want to port that over, too
mne/commands/mne_sys_info.py
Outdated
| help='Use Unicode symbols', action='store_true') | ||
| parser.add_option('-a', '--ascii', dest='unicode', | ||
| help='Use ASCII symbols', action='store_false') |
There was a problem hiding this comment.
Most (all?) other commands where we have a default we do something like this instead
| help='Use Unicode symbols', action='store_true') | |
| parser.add_option('-a', '--ascii', dest='unicode', | |
| help='Use ASCII symbols', action='store_false') | |
| help='Use Unicode symbols instead of plain ASCII', action='store_true') |
I'm also happy to push a quick commit for some of this stuff if you want a break from this stuff :) |
|
@larsoner yes, please go ahead! I didn't include the headers this time to keep the output shorter. |
|
Okay updated by iterating with @drammock during what we errantly thought were office hours trying various headers/left items etc., WDYT @cbrnr ? The checkboxes are a bit small on GitHub but decent in a terminal:
But if those are too small we could use filled squares:
|
|
Looks great! I like the checkboxes better than the filled ones, but I let you decide. Thank you! |
|
Okay back to boxes -- @drammock feel free to mark for merge if you're happy |
| mne sys_info -pd | grep "qtpy: .*{PySide6=.*}$" | ||
| mne sys_info -pd | grep "qtpy: .* (PySide6=.*)$" | ||
| pytest -m "not slowtest" ${TEST_OPTIONS} | ||
| python -m pip uninstall -yq PySide6 |
There was a problem hiding this comment.
Here I'd also uninstall PySide6-Essentials and PySide6-Addons.
|
Great work! Can we remove the colons after the package names? I don't think they're needed since we use a tabular alignment. The |
|
a few comments on this one. It runs on my laptop but it took about a minute to print. Also I get this you can see that mne-qt-browser is installed and works but the new |
* upstream/main: Fix bug in new `mne.sys_info()` (mne-tools#11577) Remove legacy plot_psd* funcs/methods in our docs and codebase (mne-tools#11563) The order of raw1.info["bads"] should not matter when concatenating with raw0.info["bads"] mne-tools#11501 (mne-tools#11502) MAINT: Fixes for matplotlib and pandas (mne-tools#11574) Fix Circle [circle deploy] Fix export to EDF format with a set physical range smaller than the data range (mne-tools#11569) Slightly rework `mne.sys_info()` (mne-tools#11568)
Fixes #11543, supersedes #11544.