Improve read_raw file extension detection#11521
Conversation
|
I would like to update our tests and try to read a file with multiple dots. For efficiency reasons, I'd like to use an existing file (e.g. |
|
Done, ready for review. |
larsoner
left a comment
There was a problem hiding this comment.
What would be the preferred way to do that (i.e. should I use tmp_path from pytest or some MNE-specific object, and should I use shutil.copy() to copy and rename the EDF file)?
Yes a copyfile using tmp_path is usually what we do. Marking as changes requested so we don't forget this part!
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
|
Done @larsoner! |
larsoner
left a comment
There was a problem hiding this comment.
Just a couple of nitpicks that don't really matter (take or leave them) plus a test enhancement that I think is worthwhile
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
|
All done! |
|
Thanks @cbrnr ! |
* upstream/main: [MAINT, MRG] Fix failing flake tests (mne-tools#11547) Improve read_raw file extension detection (mne-tools#11521) Expand user in config paths (mne-tools#11537) Ignore pkg_resources deprecations (mne-tools#11538)
Fixes #11515.