Skip to content

[BUG] Fix plot_topomap with sphere="eeglab" #11081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsoner merged 3 commits into from
Aug 24, 2022
Merged

[BUG] Fix plot_topomap with sphere="eeglab" #11081

larsoner merged 3 commits into from
Aug 24, 2022

Conversation

@mscheltienne
Copy link
Member

@mscheltienne mscheltienne commented Aug 24, 2022 •
edited
Loading

I remember seeing that it was now possible to set sphere="eeglab" but it requires that an Info gets provided to _check_sphere.

Failing on main, fixed here:

import mne


raw_fname = mne.datasets.eegbci.load_data(subject=6, runs=(1,))[0]
raw = mne.io.read_raw(raw_fname, preload=True, verbose=False)
mne.datasets.eegbci.standardize(raw)  # set channel names
raw.set_montage("standard_1005", verbose=False)

bridged_idx, ed_matrix = mne.preprocessing.compute_bridged_electrodes(raw)

mne.viz.plot_bridged_electrodes(
    raw.info, 
    bridged_idx, 
    ed_matrix, 
    topomap_args=dict(vmax=5, sphere="eeglab")
)

The test I added is a bit indirect, but it was simpler 😅

@larsoner larsoner enabled auto-merge (squash) August 24, 2022 12:01
@larsoner
Copy link
Member

larsoner commented Aug 24, 2022

LGTM, thanks in advance @mscheltienne !

@larsoner larsoner merged commit b53ed6e into mne-tools:main Aug 24, 2022
@mscheltienne mscheltienne deleted the sphere-eeglab branch August 24, 2022 13:24
larsoner added a commit to larsoner/mne-python that referenced this pull request Aug 29, 2022
@larsoner
Merge remote-tracking branch 'upstream/main' into skip
99fa0c1 
* upstream/main: (366 commits)
  BUG: Spectrum deprecation cleanup [circle deploy] (mne-tools#11115)
  Add API entry list and map (mne-tools#10999)
  Add legacy decorator (mne-tools#11097)
  [ENH, MRG] Add time-frequency epoch source estimation (mne-tools#11095)
  Revert "Add error message when conversion of EEG locs to [circle deploy] (mne-tools#11104)
  MRG: Fixes for mne-tools#11090 (mne-tools#11108)
  add test for edf units param (mne-tools#11105)
  BUG: Improve logic for bti (mne-tools#11102)
  add spectrum class (mne-tools#10184)
  ENH : add units parameter to read_raw_edf in case units is missing from the file (mne-tools#11099)
  ENH: Add temperature and galvanic (mne-tools#11090)
  Add error message when conversion of EEG locs to head space fails (mne-tools#11080)
  DOC: removed unnecessary line in PSF example (mne-tools#11085)
  FIX: Update helmet during ICP (mne-tools#11084)
  Fix various typos (mne-tools#11086)
  DOC: Rel
  BUG: don't assume that channel info contains particular keys (mne-tools#11074)
  [BUG] Fix plot_topomap with sphere="eeglab" (mne-tools#11081)
  Add `vmin` and `vmax` specification to `mne.Evoked.animate_topomap` (mne-tools#11073)
  Add _on_missing functionality to UpdateChannelsMixin (mne-tools#11077)
  ...
This was referenced Sep 3, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mscheltienne @larsoner