Conversation
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
drammock
left a comment
There was a problem hiding this comment.
please make a trivial change to tutorials/evoked/10_evoked_overview.py. Editing a tutorial will cause CircleCI to execute that tutorial so we can see what the _repr_html_ actually looks like, before merging.
doc/changes/latest.inc
Outdated
| - :meth:`mne.Epochs.plot_psd_topomap` now suppresses redundant colorbars when ``vlim='joint'`` (:gh:`11051` by `Daniel McCloy`_) | ||
| - Add ``starting_affine`` keyword argument to :func:`mne.transforms.compute_volume_registration` to initialize an alignment with an affine (:gh:`11020` by `Alex Rockhill`_) | ||
| - The ``trans`` parameter in :func:`mne.make_field_map` now accepts a :class:`~pathlib.Path` object, and uses standardised loading logic (:gh:`10784` by :newcontrib:`Andrew Quinn`) | ||
| - Add HTML representation for `~mne.Epochs` and `~mne.Evoked` in Jupyter Notebooks (:gh:`9220` by `Valerii Chirkov`_) |
There was a problem hiding this comment.
this will need to be updated. add your name after Valerii
drammock
left a comment
There was a problem hiding this comment.
please change line 261 of the tutorial from print(left_right_aud) to simply left_right_aud (this will trigger the _repr_html_, I forgot that explicitly calling print will override it).
Note also that I edited the PR description to explicitly use the word closes so that the issue and the other PR will automatically close when this one gets merged.
Co-authored-by: Daniel McCloy <dan@mccloy.info>
|
Thanks @drammock - that makes sense. Hopefully fixed in the last commit. |
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
Reference issue
closes #9177
supersedes and thus closes #9220
What does this implement/fix?
This takes the _repr_html method from #9220 and updates it to use the neew jinja2 templates.