Skip to content

ENH: add _repr_html_ method in the class mne.Evoked#9220

Closed
vagechirkov wants to merge 12 commits intomne-tools:mainfrom
vagechirkov:add-repr-html-evoked
Closed

ENH: add _repr_html_ method in the class mne.Evoked#9220
vagechirkov wants to merge 12 commits intomne-tools:mainfrom
vagechirkov:add-repr-html-evoked

Conversation

@vagechirkov
Copy link
Copy Markdown
Contributor

@vagechirkov vagechirkov commented Mar 30, 2021

Reference issue #9177

Add _repr_html_ for mne.Evoked:

image
(updated image)

Copy link
Copy Markdown
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
vagechirkov and others added 3 commits March 30, 2021 23:44
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Copy link
Copy Markdown
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

evoked_template = Template("""
<table class="table table-hover">
<tr>
<th>Content</th>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm starting to think that maybe we should just call this Conditions? WDYT?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original Comment is also an option :)

@hoechenberger
Copy link
Copy Markdown
Member

@vagechirkov Are you willing to revive this? I think it would still be awesome to have this improvement in the next MNE-Python release! <3

@hoechenberger hoechenberger added this to the 1.0 milestone Nov 6, 2021
@larsoner larsoner modified the milestones: 1.0, 1.1 Feb 11, 2022
@larsoner larsoner modified the milestones: 1.1, 1.2 Jun 4, 2022
@AJQuinn AJQuinn mentioned this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

5 participants