Drop EEG rejection thresholds when replacing EEG with CSD channels #10619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to fix the issue reported at https://mne.discourse.group/t/saving-epoch-error-no-eeg-channel-found
Member
Author
|
If anyone's willing to take this one over, please feel free to do so as I'm very much busy with other stuff |
hoechenberger
commented
May 10, 2022
Contributor
|
@hoechenberger, I didn't update the docstring, I'm really not sure what it would say, I don't think this is a user-facing change. I think the behavior is now what's expected as in the epochs can be saved and loaded from a disk with a rejection threshold applied. You could add something to explain about that your rejection threshold for |
Member
Author
|
Great work, @alexrockhill! And I agree, I think we don't need a docstring update after all. Feel free to merge once CI goes green! |
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Contributor
|
Is there a fix to the pandas install in the works or are we merging without those tests? |
Member
Author
|
I'd leave this decision to @larsoner |
Contributor
|
Thanks @hoechenberger! |
Member
Author
|
Thanks for bringing this home! |
agramfort
reviewed
May 11, 2022
Comment on lines
+182
to
+183
| inst.reject = None if inst.reject is None else \ | ||
| {k: v for k, v in inst.reject.items() if k != 'eeg'} |
Member
There was a problem hiding this comment.
if inst.reject and "eeg" in inst.reject:
del inst.reject["eeg"]
would be more readable.
Member
Author
There was a problem hiding this comment.
Good idea!
I'll push a "fix"
hoechenberger
added a commit
to hoechenberger/mne-python
that referenced
this pull request
May 11, 2022
Merged
hoechenberger
added a commit
that referenced
this pull request
May 11, 2022
hoechenberger
added a commit
to hoechenberger/mne-python
that referenced
this pull request
May 11, 2022
…ne-tools#10619) * Drop EEG rejection thresholds when replacing EEG with CSD channels This is an attempt to fix the issue reported at https://mne.discourse.group/t/saving-epoch-error-no-eeg-channel-found * fix, working version * Update doc/changes/latest.inc Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com> Co-authored-by: Alex <aprockhill@mailbox.org>
hoechenberger
added a commit
to hoechenberger/mne-python
that referenced
this pull request
May 11, 2022
larsoner
added a commit
that referenced
this pull request
May 11, 2022
* Drop EEG rejection thresholds when replacing EEG with CSD channels (#10619) * Drop EEG rejection thresholds when replacing EEG with CSD channels This is an attempt to fix the issue reported at https://mne.discourse.group/t/saving-epoch-error-no-eeg-channel-found * fix, working version * Update doc/changes/latest.inc Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com> Co-authored-by: Alex <aprockhill@mailbox.org> * Simplify #10619 (#10620) * MAINT: Fix * FIX: Fix for regression * FIX: Fix for pandas * FIX: Better fix * FIX: Adjust Co-authored-by: Alex <aprockhill@mailbox.org> Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
larsoner
added a commit
to HanBnrd/mne-python
that referenced
this pull request
May 17, 2022
* upstream/main: (24 commits) Use less memory when loading EDF file (mne-tools#10638) BUG: fix ipython console accessibility after MNEQtBrowser in Spyder (mne-tools#10637) WIP: Fix mne.time_frequency.multitaper Nyquist adjustment slightly incorrect (mne-tools#10541) BUG: Fix bug with fNIRS reordering (mne-tools#10630) MNT: PyQt6 for pip pre 3.10 (mne-tools#10636) CI: Fix conda (mne-tools#10628) MRG: Update installer links to point to 1.0.3_0 (mne-tools#10622) [BUG, MRG] fix info write access (mne-tools#10626) [MRG] Fixed group_by titles in evoked_plot. (mne-tools#10618) [BUG, MRG] Replace image_interp with interpolation in topomap plot arguments (mne-tools#10617) MAINT: Fix timeout (mne-tools#10624) Simplify mne-tools#10619 (mne-tools#10620) Drop EEG rejection thresholds when replacing EEG with CSD channels (mne-tools#10619) Add get_montage support for fNIRS (mne-tools#10611) ENH: Improve make_head_surface options (mne-tools#10592) [ENH, MRG] Add citation for intracranial JOSS paper (mne-tools#10616) [ENH] Add sys info for mne-icalabel (mne-tools#10615) MRG: Add "highlight" parameter to Evoked.plot() to conveniently highlight time periods (mne-tools#10614) MRG: Allow to pass array of "average" values to plot_evoked_topomap() (mne-tools#10610) fix: snirf length units (mne-tools#10613) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the issue reported at https://mne.discourse.group/t/saving-epoch-error-no-eeg-channel-found
WIP: