Skip to content

[MRG] _part- -> _split- to conform with BIDS #417

Merged
jasmainak merged 6 commits intomne-tools:masterfrom
sappelhoff:part
May 19, 2020
Merged

[MRG] _part- -> _split- to conform with BIDS #417
jasmainak merged 6 commits intomne-tools:masterfrom
sappelhoff:part

Conversation

@sappelhoff
Copy link
Copy Markdown
Member

@sappelhoff sappelhoff commented May 18, 2020 •
edited
Loading

see: bids-standard/bids-specification#460

to be merged before CIs pass:

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"
  • Commit history does not contain any merge commits

@sappelhoff sappelhoff mentioned this pull request May 18, 2020
Merged
5 tasks
@sappelhoff sappelhoff mentioned this pull request May 18, 2020
Closed
jasmainak
jasmainak reviewed May 18, 2020
View reviewed changes
@sappelhoff
Copy link
Copy Markdown
Member Author

sappelhoff commented May 19, 2020

appveyor is green, so I trust that Travis will also be green soon.

This is ready to be merged and then we can close this chapter :-)

jasmainak
jasmainak reviewed May 19, 2020
View reviewed changes
.travis.yml
global:
# can be "stable", or anything that can be used with git checkout
- VALIDATOR_VERSION="8887074e5f5f48a768842ffcf96fb2952dbe0e38"
- VALIDATOR_VERSION="e457907ca9af4c32aede828117ea5a43737b4597"
Copy link
Copy Markdown
Member

@jasmainak jasmainak May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this random commit??! the stable branch doesn't yet work?

Copy link
Copy Markdown
Member Author

@sappelhoff sappelhoff May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bids-validator releases very often (sometimes even twice a week), so I find it more "stable" for us to regularly pin to an up to date commit.

that particular commit corresponds to my merge of the split rules into the validator.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2020 •
edited
Loading

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files          11       11           
  Lines        1528     1528           
=======================================
  Hits         1442     1442           
  Misses         86       86
Impacted Files Coverage Δ
mne_bids/utils.py 98.52% <ø> (ø)
mne_bids/write.py 97.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102de3e...62a7e14. Read the comment docs.

@jasmainak jasmainak merged commit fb6e670 into mne-tools:master May 19, 2020
@jasmainak
Copy link
Copy Markdown
Member

jasmainak commented May 19, 2020

Thanks @sappelhoff !

@sappelhoff sappelhoff deleted the part branch May 19, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agramfort agramfort agramfort approved these changes

@jasmainak jasmainak jasmainak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sappelhoff @codecov-commenter @jasmainak @agramfort