Merged
Conversation
Member
Author
|
@Mergifyio backport dev |
✅ Backports have been createdDetails
|
wks
approved these changes
Jan 6, 2025
| .generate() | ||
| // Unwrap the Result and panic on failure. | ||
| .expect("Unable to generate bindings"); | ||
| if !Path::new(format!("{}/mmtk/src/julia_types.rs", mmtk_dir).as_str()).exists() { |
Contributor
There was a problem hiding this comment.
Using format! should work, just like those existing lines that contain format!. But my intuition tells me it is more robust to use Path::join of PathBuf to construct paths. We may investigate it later, but the current change looks good to me.
mergify bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
This PR updates the pinned Rust version to 1.83, and updates mmtk-core to mmtk/mmtk-core#1253. (cherry picked from commit 73e9c84) # Conflicts: # .github/mergify.yml # mmtk/Cargo.lock # mmtk/Cargo.toml
qinsoon
added a commit
that referenced
this pull request
Jan 9, 2025
This PR updates the pinned Rust version to 1.83, and updates mmtk-core to https://github.com/mmtk/mmtk-core/pull/1253.<hr>This is an automatic backport of pull request #211 done by [Mergify](https://mergify.com). --------- Co-authored-by: Yi Lin <qinsoon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the pinned Rust version to 1.83, and updates mmtk-core to mmtk/mmtk-core#1253.