Closed
Conversation
Owner
Author
|
Preserving this as-is. Rebased on latest and continued work in #4. |
mmcloughlin
added a commit
that referenced
this pull request
Oct 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shows adhoc support for symbolic opcodes.
Changes
opargument todis_decode_entryis changed fromvaluetosymtype. This change cascades throughout thedisfunctions.sym_inmaskimplementation with simplification rules.primops.asli:adhoccommand for testing purposes. We would need an actual user interface if we were going to land this.Example
For comparison, when you ask for semantics for a concrete add immediate:
ASLp can now execute opcodes that are expressions. For example the assembly template
add x7, x8, #<imm>would be the opcode concatenation0x244:imm:0x107. It now gives the semantics: