[Serving] Avoid creating an output artifact in serving job without respond() [1.10.x]
#9104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…respond()` [ML-11400](https://iguazio.atlassian.net/browse/ML-11400) Also: * Avoid creating per-model artifacts when the output schema doesn't fit * Avoid failing the job if per-model artifact creation fails * Expand tests to cover output artifacts * Fix minor static code analysis warning
respond()respond() [1.10.x]
danielperezz
approved these changes
Dec 22, 2025
Contributor
danielperezz
left a comment
There was a problem hiding this comment.
Looks great! had just one comment, not directly related to your changes
| df = data.as_df() | ||
|
|
||
| if df.empty: | ||
| context.logger.warn("Job terminated due to empty inputs (0 rows)") |
Contributor
There was a problem hiding this comment.
Perhaps we should consider adding after this line:
context.log_result("num_rows", run_call_count) # run_call_count=0
Collaborator
Author
There was a problem hiding this comment.
But the input is empty, and run_call_count will necessarily always be zero? It doesn't get incremented until later in the function.
gtopper
added a commit
to gtopper/mlrun
that referenced
this pull request
Dec 22, 2025
…respond()` Forward-port of mlrun#9104. [ML-11400](https://iguazio.atlassian.net/browse/ML-11400) Also: * Avoid creating per-model artifacts when the output schema doesn't fit * Avoid failing the job if per-model artifact creation fails * Expand tests to cover output artifacts * Fix minor static code analysis warning
assaf758
pushed a commit
that referenced
this pull request
Dec 22, 2025
…espond()` (#9106) Forward-port of #9104. [ML-11400](https://iguazio.atlassian.net/browse/ML-11400) Also: * Avoid creating per-model artifacts when the output schema doesn't fit * Avoid failing the job if per-model artifact creation fails * Expand tests to cover output artifacts * Fix minor static code analysis warning [ML-11400]: https://iguazio.atlassian.net/browse/ML-11400?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
omermaim
added a commit
to omermaim/mlrun
that referenced
this pull request
Dec 28, 2025
…thout `respond()` [1.10.x] (mlrun#9104)" This reverts commit d48a638.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ML-11400
Also: