[Model Monitoring] Remove sniffio from the Evidently app requirements [1.10.x]
#9067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…10.x] (mlrun#9045)" This reverts commit 4c90a53.
sniffio [1.10.x]sniffio from the Evidently app requirements [1.10.x]
Member
|
@jond01 why do you need to update the lockfiles? |
jond01
commented
Dec 17, 2025
| --hash=sha256:be8f91813854722b7a2f37cbb57d76977050a96b2427d3c4455d406f0f4fcd50 | ||
| litestar==2.19.0 \ | ||
| --hash=sha256:849971d097a6118f81235531fc0f342d797bd29d9aef9c23230559f124d16247 \ | ||
| --hash=sha256:c2663a7f48a7ed273615260c23fc76dbef2ca0d539ece25318772b737470c531 |
Member
Author
There was a problem hiding this comment.
@assaf758 the lock files update is needed for this
Comment on lines
-3002
to
+3003
| litestar==2.18.0 \ | ||
| --hash=sha256:459ec993bafe47245c981d802a0a0c73f47c98313b3c4e47923eebe978f0e511 \ | ||
| --hash=sha256:be8f91813854722b7a2f37cbb57d76977050a96b2427d3c4455d406f0f4fcd50 | ||
| litestar==2.19.0 \ | ||
| --hash=sha256:849971d097a6118f81235531fc0f342d797bd29d9aef9c23230559f124d16247 \ | ||
| --hash=sha256:c2663a7f48a7ed273615260c23fc76dbef2ca0d539ece25318772b737470c531 |
assaf758
approved these changes
Dec 17, 2025
jond01
added a commit
to jond01/mlrun
that referenced
this pull request
Dec 17, 2025
…ts [1.10.x] (mlrun#9067) ### 📝 Description Revert mlrun#9045 following [`litestar` 2.19.0](https://github.com/litestar-org/litestar/releases/tag/v2.19.0). --- ### 🛠️ Changes Made Remove the explicit `sniffio` requirement from the Evidently app and update the lock files. --- ### ✅ Checklist - [x] I have tested the changes in this PR - [x] I confirmed whether my changes are covered by system tests --- ### 🧪 Testing I ran `"tests/system/model_monitoring/test_app.py::TestMonitoringAppFlow::test_app_flow[True-True]"` and it passed successfully. --- ### 🔗 References - Ticket link: [ML-11776](https://iguazio.atlassian.net/browse/ML-11776) --- ### 🚨 Breaking Changes? - [x] No [ML-11776]: https://iguazio.atlassian.net/browse/ML-11776?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ # Conflicts: # dockerfiles/gpu/locked-requirements.txt # dockerfiles/jupyter/locked-requirements.txt # dockerfiles/mlrun-api/locked-requirements.txt # dockerfiles/mlrun-kfp/locked-requirements.txt # dockerfiles/mlrun/locked-requirements.txt # dockerfiles/test-system/locked-requirements.txt # dockerfiles/test/locked-requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Revert #9045 following
litestar2.19.0.🛠️ Changes Made
Remove the explicit
sniffiorequirement from the Evidently app and update the lock files.✅ Checklist
🧪 Testing
I ran
"tests/system/model_monitoring/test_app.py::TestMonitoringAppFlow::test_app_flow[True-True]"and it passed successfully.🔗 References
🚨 Breaking Changes?