Skip to content

Conversation

@liranbg
Copy link
Member

@liranbg liranbg commented Dec 4, 2025

📝 Description

Chief spam itself with needless logs

> 2025-12-04 13:57:23,060 [debug] Retrying jobs with retry policy configured: {"ctx":"003e5c1b-28e4-440b-a4ec-88011f4dd27d"}
> 2025-12-04 13:57:39,138 [debug] Paginating runs from KFP: {"ctx":"6ea0fb48-bc2a-47f3-8af7-3121073e3fc1","experiment_id":null,"filter_":"{\"predicates\":[{\"key\":\"created_at\",\"op\":5,\"timestamp_value\":\"2025-11-27T13:57:39.108269Z\"}]}","namespace":null,"page_size":200,"page_token":null,"sort_by":null}
> 2025-12-04 13:57:39,143 [debug] Listing runs from KFP: {"ctx":"6ea0fb48-bc2a-47f3-8af7-3121073e3fc1","experiment_id":null,"filter_json":"{\"predicates\":[{\"key\":\"created_at\",\"op\":5,\"timestamp_value\":\"2025-11-27T13:57:39.108269Z\"}]}","namespace":null,"page_size":200,"page_token":"","sort_by":""}
> 2025-12-04 13:57:39,150 [debug] Checking notifications since last end time: {"ctx":"adf4aa56-7a01-4085-a182-fca4a1ad60f9","end_time_from":"2025-12-04T13:57:04.057338+00:00","last_update_time":"2025-12-04T13:57:09.057338+00:00"}
> 2025-12-04 13:57:39,152 [debug] Finished paginating runs from KFP: {"ctx":"6ea0fb48-bc2a-47f3-8af7-3121073e3fc1","fetched_run_count":0,"filter_json":"{\"predicates\":[{\"key\":\"created_at\",\"op\":5,\"timestamp_value\":\"2025-11-27T13:57:39.108269Z\"}]}","page_size":200,"page_token":null,"sort_by":null}
> 2025-12-04 13:57:39,154 [debug] No runs ended during the current window: {"ctx":"adf4aa56-7a01-4085-a182-fca4a1ad60f9","end_time_from":"2025-12-04T13:57:04.057338+00:00"}

over and over again, needlessly.


🛠️ Changes Made

Remove needless logs


✅ Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR
  • I confirmed whether my changes are covered by system tests
    • If yes, I ran all relevant system tests and ensured they passed before submitting this PR
    • I updated existing system tests and/or added new ones if needed to cover my changes
  • If I introduced a deprecation:

🧪 Testing

N/A


🔗 References

  • Ticket link:
  • Design docs links:
  • External links:

🚨 Breaking Changes?

  • Yes (explain below)
  • No

🔍️ Additional Notes

Copy link
Member

@rokatyy rokatyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@weilerN weilerN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a general suggestion regarding the logs

@liranbg liranbg merged commit 34d29dc into mlrun:1.10.x Dec 4, 2025
18 checks passed
liranbg added a commit to liranbg/mlrun that referenced this pull request Dec 4, 2025
Chief spam itself with needless logs

```
> 2025-12-04 13:57:23,060 [debug] Retrying jobs with retry policy configured: {"ctx":"003e5c1b-28e4-440b-a4ec-88011f4dd27d"}
> 2025-12-04 13:57:39,138 [debug] Paginating runs from KFP: {"ctx":"6ea0fb48-bc2a-47f3-8af7-3121073e3fc1","experiment_id":null,"filter_":"{\"predicates\":[{\"key\":\"created_at\",\"op\":5,\"timestamp_value\":\"2025-11-27T13:57:39.108269Z\"}]}","namespace":null,"page_size":200,"page_token":null,"sort_by":null}
> 2025-12-04 13:57:39,143 [debug] Listing runs from KFP: {"ctx":"6ea0fb48-bc2a-47f3-8af7-3121073e3fc1","experiment_id":null,"filter_json":"{\"predicates\":[{\"key\":\"created_at\",\"op\":5,\"timestamp_value\":\"2025-11-27T13:57:39.108269Z\"}]}","namespace":null,"page_size":200,"page_token":"","sort_by":""}
> 2025-12-04 13:57:39,150 [debug] Checking notifications since last end time: {"ctx":"adf4aa56-7a01-4085-a182-fca4a1ad60f9","end_time_from":"2025-12-04T13:57:04.057338+00:00","last_update_time":"2025-12-04T13:57:09.057338+00:00"}
> 2025-12-04 13:57:39,152 [debug] Finished paginating runs from KFP: {"ctx":"6ea0fb48-bc2a-47f3-8af7-3121073e3fc1","fetched_run_count":0,"filter_json":"{\"predicates\":[{\"key\":\"created_at\",\"op\":5,\"timestamp_value\":\"2025-11-27T13:57:39.108269Z\"}]}","page_size":200,"page_token":null,"sort_by":null}
> 2025-12-04 13:57:39,154 [debug] No runs ended during the current window: {"ctx":"adf4aa56-7a01-4085-a182-fca4a1ad60f9","end_time_from":"2025-12-04T13:57:04.057338+00:00"}
```

over and over again, needlessly.

---

Remove needless logs

---

- [ ] I updated the documentation (if applicable)
- [ ] I have tested the changes in this PR
- [ ] I confirmed whether my changes are covered by system tests
- [ ] If yes, I ran all relevant system tests and ensured they passed
before submitting this PR
- [ ] I updated existing system tests and/or added new ones if needed to
cover my changes
- [ ] If I introduced a deprecation:
  - [ ] I followed the [Deprecation Guidelines](./DEPRECATION.md)
  - [ ] I updated the relevant Jira ticket for documentation

---

N/A

---

- Ticket link:
- Design docs links:
- External links:

---

- [ ] Yes (explain below)
- [x] No

<!-- If yes, describe what needs to be changed downstream: -->

---

<!-- Anything else reviewers should know (follow-up tasks, known issues,
affected areas etc.). -->
<!-- ### 📸 Screenshots / Logs -->

(cherry picked from commit 34d29dc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants