[Model Monitoring] Add TimescaleDB database auto-creation #9012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automatic database creation for TimescaleDB connector. When `auto_create_database` is enabled (default), the connector generates a database name using `system_id` and creates it if it doesn't exist. Changes: - Add `tsdb.auto_create_database` config option (default: True) - Add `admin_dsn()` method to `DatastoreProfilePostgreSQL` - Add `dsn(database=...)` parameter override - Add `_determine_database_name()` to `TimescaleDBConnector` - Add `_create_db_if_not_exists()` to `TimescaleDBOperationsManager` - Add unit tests for database auto-creation functionality
gtopper
reviewed
Dec 9, 2025
mlrun/model_monitoring/db/tsdb/timescaledb/timescaledb_connector.py
Outdated
Show resolved
Hide resolved
mlrun/model_monitoring/db/tsdb/timescaledb/timescaledb_connector.py
Outdated
Show resolved
Hide resolved
tests/model_monitoring/db/tsdb/timescaledb/test_timescaledb_connector.py
Outdated
Show resolved
Hide resolved
tests/model_monitoring/db/tsdb/timescaledb/test_timescaledb_connector.py
Outdated
Show resolved
Hide resolved
tests/model_monitoring/db/tsdb/timescaledb/test_timescaledb_connector.py
Outdated
Show resolved
Hide resolved
tests/model_monitoring/db/tsdb/timescaledb/test_timescaledb_connector.py
Outdated
Show resolved
Hide resolved
tests/model_monitoring/db/tsdb/timescaledb/test_timescaledb_connector.py
Outdated
Show resolved
Hide resolved
gtopper
reviewed
Dec 15, 2025
mlrun/model_monitoring/db/tsdb/timescaledb/timescaledb_operations.py
Outdated
Show resolved
Hide resolved
alxtkr77
pushed a commit
to alxtkr77/mlrun
that referenced
this pull request
Dec 15, 2025
Changes based on PR mlrun#9012 review: 1. URL encoding consistency in DatastoreProfiles: - Add URL encoding for user/password in dsn() methods - Add URL decoding in from_dsn() methods (urlparse doesn't decode) - Fix affects PostgreSQL, TDEngine, and Redis profiles - Add comprehensive tests for URL encoding round-trips 2. Terminology improvements: - Replace "maintenance database" with "default postgres database" - Replace "target database" with "monitoring database" 3. TimescaleDBConnection improvements: - Add close() method for proper encapsulation - Update timescaledb_operations to use close() instead of _pool.close()
alxtkr77
pushed a commit
to alxtkr77/mlrun
that referenced
this pull request
Dec 15, 2025
Changes based on PR mlrun#9012 review: 1. URL encoding consistency in DatastoreProfiles: - Add URL encoding for user/password in dsn() methods - Add URL decoding in from_dsn() methods (urlparse doesn't decode) - Fix affects PostgreSQL, TDEngine, and Redis profiles - Add comprehensive tests for URL encoding round-trips 2. Terminology improvements: - Replace "maintenance database" with "default postgres database" - Replace "target database" with "monitoring database" 3. TimescaleDBConnection improvements: - Add close() method for proper encapsulation - Update timescaledb_operations to use close() instead of _pool.close()
alxtkr77
pushed a commit
to alxtkr77/mlrun
that referenced
this pull request
Dec 15, 2025
Changes based on PR mlrun#9012 review: 1. URL encoding consistency in DatastoreProfiles: - Add URL encoding for user/password in dsn() methods - Add URL decoding in from_dsn() methods (urlparse doesn't decode) - Fix affects PostgreSQL, TDEngine, and Redis profiles - Add comprehensive tests for URL encoding round-trips 2. Terminology improvements: - Replace "maintenance database" with "default postgres database" - Replace "target database" with "monitoring database" 3. TimescaleDBConnection improvements: - Add close() method for proper encapsulation - Update timescaledb_operations to use close() instead of _pool.close()
gtopper
reviewed
Dec 16, 2025
gtopper
approved these changes
Dec 16, 2025
Collaborator
gtopper
left a comment
There was a problem hiding this comment.
Other than that, LGTM ✅
alxtkr77
pushed a commit
to alxtkr77/mlrun
that referenced
this pull request
Dec 16, 2025
Changes based on PR mlrun#9012 review: 1. URL encoding consistency in DatastoreProfiles: - Add URL encoding for user/password in dsn() methods - Add URL decoding in from_dsn() methods (urlparse doesn't decode) - Fix affects PostgreSQL, TDEngine, and Redis profiles - Add comprehensive tests for URL encoding round-trips 2. Terminology improvements: - Replace "maintenance database" with "default postgres database" - Replace "target database" with "monitoring database" 3. TimescaleDBConnection improvements: - Add close() method for proper encapsulation - Update timescaledb_operations to use close() instead of _pool.close()
Changes based on PR mlrun#9012 review: 1. URL encoding consistency in DatastoreProfiles: - Add URL encoding for user/password in dsn() methods - Add URL decoding in from_dsn() methods (urlparse doesn't decode) - Fix affects PostgreSQL, TDEngine, and Redis profiles - Add comprehensive tests for URL encoding round-trips 2. Terminology improvements: - Replace "maintenance database" with "default postgres database" - Replace "target database" with "monitoring database" 3. TimescaleDBConnection improvements: - Add close() method for proper encapsulation - Update timescaledb_operations to use close() instead of _pool.close()
gtopper
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE: [Model Monitoring] Add TimescaleDB database auto-creation
Summary
Add automatic database creation for TimescaleDB connector. When
auto_create_databaseis enabled (default), the connector generates a database name usingsystem_idand creates it if it does not exist.Changes Made
tsdb.auto_create_databaseconfig option tomlrun/config.py(default: True)admin_dsn()method toDatastoreProfilePostgreSQLfor connecting to postgres maintenance databasedsn(database=...)parameter to override database in DSN_determine_database_name()toTimescaleDBConnector_create_db_if_not_exists()toTimescaleDBOperationsManageradmin_dsn()anddsn()methods (2 tests)Testing
Checklist
Reference