[CI] Simplify install-complete-requirements to include kfp18
#9009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
577a3a7 to
f48fa1a
Compare
alxtkr77
approved these changes
Dec 4, 2025
10 tasks
liranbg
added a commit
that referenced
this pull request
Dec 7, 2025
### 📝 Description side effect of #9009 where I deleted `install-complete-kfp-requirements` in favor to `install-complete-requirements`. --- ### 🛠️ Changes Made Removed leftovers --- ### ✅ Checklist - [ ] I updated the documentation (if applicable) - [ ] I have tested the changes in this PR - [ ] I confirmed whether my changes are covered by system tests - [ ] If yes, I ran all relevant system tests and ensured they passed before submitting this PR - [ ] I updated existing system tests and/or added new ones if needed to cover my changes - [ ] If I introduced a deprecation: - [ ] I followed the [Deprecation Guidelines](./DEPRECATION.md) - [ ] I updated the relevant Jira ticket for documentation --- ### 🧪 Testing <!-- - How it was tested (unit tests, manual, integration) --> <!-- - Any special cases covered. --> --- ### 🔗 References - Ticket link: - Design docs links: - External links: --- ### 🚨 Breaking Changes? - [ ] Yes (explain below) - [ ] No <!-- If yes, describe what needs to be changed downstream: --> --- ### 🔍️ Additional Notes <!-- Anything else reviewers should know (follow-up tasks, known issues, affected areas etc.). --> <!-- ### 📸 Screenshots / Logs -->
liranbg
added a commit
to liranbg/mlrun
that referenced
this pull request
Dec 9, 2025
…#9009) ### 📝 Description Having 2 commands to install complete made the CI tricky and not covering the part where it needs to install kfp18 causing some failures later on when kfp18 and requirement were conflicting. since we have CI step that installs all requirement to ensure they are not conflicting - unify both install commands make sense to ensure robustness. --- ### 🛠️ Changes Made moved kfp18 installation to default install complete requirements. --- ### ✅ Checklist - [ ] I updated the documentation (if applicable) - [ ] I have tested the changes in this PR - [ ] I confirmed whether my changes are covered by system tests - [ ] If yes, I ran all relevant system tests and ensured they passed before submitting this PR - [ ] I updated existing system tests and/or added new ones if needed to cover my changes - [ ] If I introduced a deprecation: - [ ] I followed the [Deprecation Guidelines](./DEPRECATION.md) - [ ] I updated the relevant Jira ticket for documentation --- ### 🧪 Testing Locally installed commads --- ### 🔗 References - Ticket link: https://iguazio.atlassian.net/browse/ML-11661 - Design docs links: - External links: --- ### 🚨 Breaking Changes? - [ ] Yes (explain below) - [x] No <!-- If yes, describe what needs to be changed downstream: --> --- ### 🔍️ Additional Notes <!-- Anything else reviewers should know (follow-up tasks, known issues, affected areas etc.). --> <!-- ### 📸 Screenshots / Logs -->
liranbg
added a commit
to liranbg/mlrun
that referenced
this pull request
Dec 9, 2025
side effect of mlrun#9009 where I deleted `install-complete-kfp-requirements` in favor to `install-complete-requirements`. --- Removed leftovers --- - [ ] I updated the documentation (if applicable) - [ ] I have tested the changes in this PR - [ ] I confirmed whether my changes are covered by system tests - [ ] If yes, I ran all relevant system tests and ensured they passed before submitting this PR - [ ] I updated existing system tests and/or added new ones if needed to cover my changes - [ ] If I introduced a deprecation: - [ ] I followed the [Deprecation Guidelines](./DEPRECATION.md) - [ ] I updated the relevant Jira ticket for documentation --- <!-- - How it was tested (unit tests, manual, integration) --> <!-- - Any special cases covered. --> --- - Ticket link: - Design docs links: - External links: --- - [ ] Yes (explain below) - [ ] No <!-- If yes, describe what needs to be changed downstream: --> --- <!-- Anything else reviewers should know (follow-up tasks, known issues, affected areas etc.). --> <!-- ### 📸 Screenshots / Logs -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Having 2 commands to install complete made the CI tricky and not covering the part where it needs to install kfp18 causing some failures later on when kfp18 and requirement were conflicting. since we have CI step that installs all requirement to ensure they are not conflicting - unify both install commands make sense to ensure robustness.
🛠️ Changes Made
moved kfp18 installation to default install complete requirements.
✅ Checklist
🧪 Testing
Locally installed commads
🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes